Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibWeb: Update 'default.css' for 'audio' element UA rule with no control #22767

Open
Ahmad-S792 opened this issue Jan 15, 2024 · 0 comments
Open

Comments

@Ahmad-S792
Copy link

Hi Folks,

I noticed that all browsers have following rule in their UA stylesheets:

audio:not([controls]) {
  display: none !important;
}

It is not in web-spec directly as 'UA' stylesheet recommendation but it is in web-spec:

https://html.spec.whatwg.org/#embedded-content-rendering-rules

"When an audio element is not exposing a user interface, the user agent is expected
to force its 'display' property to compute to 'none', irrespective of CSS rules."

I added it late in WebKit (shipped in Safari 16.4), so it would be good to add it straight-away and get away from 'BrowserCompat' issue.

Just wanted to raise so it can be at least tracked. I can do PR to add but I cannot test it (like compile etc.).

Thanks!

@Ahmad-S792 Ahmad-S792 changed the title LibWeb: Update 'default.css' to add 'audio' element rule when the controls are disabled LibWeb: Update 'default.css' for 'audio' element UA rule with no control Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: No status
Development

Successfully merging a pull request may close this issue.

2 participants