Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brush keybind black border #191

Open
joshua-dean opened this issue Oct 3, 2024 · 1 comment
Open

Brush keybind black border #191

joshua-dean opened this issue Oct 3, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@joshua-dean
Copy link
Collaborator

joshua-dean commented Oct 3, 2024

very cool. one weird thing i noticed is that if you click the brush buttons and/or annotation size buttons and then use a keybind for the same to toggle, then your previously clicked option stays with a black border. not a huge deal, just unexpected and maybe slightly confusing. clearly not introduced in this pr so dont have to fix it now

steps to reproduce:

  1. click on the brush/erase button in the toolbox
  2. use a keybind (g or e) to toggle or switch brush mode
  3. the active class disappears, but a black border remains

brush

Originally posted by @TrevorBurgoyne in #188 (review)

@joshua-dean joshua-dean added the bug Something isn't working label Oct 3, 2024
@joshua-dean
Copy link
Collaborator Author

As mentioned here, I can reproduce this in Chrome but not in Firefox.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant