Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate a build is in progress in Dashboard build page #2542

Closed
humphd opened this issue Nov 29, 2021 · 6 comments · Fixed by #2665
Closed

Indicate a build is in progress in Dashboard build page #2542

humphd opened this issue Nov 29, 2021 · 6 comments · Fixed by #2665
Assignees
Labels
area: dashboard Related to Telescope's dashboard (the page that has stats) developer experience Helping the Developer Experience type: enhancement New feature or request

Comments

@humphd
Copy link
Contributor

humphd commented Nov 29, 2021

When I go to a build in GitHub Actions, I get an animated indication that a build is happening, and how long it's been going for:

Screen Shot 2021-11-29 at 9 55 32 AM

When it's done, the yellow animated circle becomes a green check mark or a red 'x'.

Screen Shot 2021-11-29 at 9 58 45 AM

Let's do something like this in our build dashboard, so you know what's happening when you get there. Especially when a build step is not producing any output, it can be hard to know if it's still going.

@humphd humphd added type: enhancement New feature or request developer experience Helping the Developer Experience area: dashboard Related to Telescope's dashboard (the page that has stats) labels Nov 29, 2021
@Yoda-Canada
Copy link
Contributor

@humphd can I work on this issue?

@humphd
Copy link
Contributor Author

humphd commented Nov 29, 2021

Sure thing, assigned.

@Yoda-Canada
Copy link
Contributor

@humphd Do I need to add the animated indication to each section?
764667048d4dd311a1e8b376341f2eb

@humphd
Copy link
Contributor Author

humphd commented Nov 29, 2021

Not on that page, on the build page, probably in the header:

https://dev.api.telescope.cdot.systems/v1/status/pages/build.html

@Yoda-Canada
Copy link
Contributor

What is the purpose of this log and who will build it? I can't find the relevant information in README and CONTRIBUTING.

@humphd
Copy link
Contributor Author

humphd commented Nov 29, 2021

Aren't you also working on #2519, which is related to this as well?

The autodeployment server builds our containers when someone merges/tags on GitHub, and deploys it to staging or production. We stream that log and the build log page displays it in the terminal.

The log is available from https://dev.api.telescope.cdot.systems/deploy/log (404 if no log is happening) and the build status is at https://dev.api.telescope.cdot.systems/deploy/status.

This issue is about using the status and log info to create some kind of header that indicates if the build is happening or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dashboard Related to Telescope's dashboard (the page that has stats) developer experience Helping the Developer Experience type: enhancement New feature or request
Projects
None yet
2 participants