Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show clickable cursor on post titles that can't be expanded #1398

Open
humphd opened this issue Nov 18, 2020 · 4 comments
Open

Don't show clickable cursor on post titles that can't be expanded #1398

humphd opened this issue Nov 18, 2020 · 4 comments
Labels
5 min fix Fixable in 5 minutes or less area: css styling Anything related to CSS styling area: front-end type: enhancement New feature or request

Comments

@humphd
Copy link
Contributor

humphd commented Nov 18, 2020

What would you like to be added:

We have a neat new feature where you can click-to-expand post headers that are really long (added in #1380). It works great, but in the case that a post title is not long enough to need expanding, the click does nothing:

expandable-header-bug

Let's see if we can only add the CSS cursor pointer when the post title is actually clickable. Another solution might be to make the ellipses (...) clickable instead? Not sure if that's good UX or even possible, though.

Why would you like this to be added:

It's odd to have UI that says "click here" but then clicking seems to have no effect. It would be better not to give the user the hint that something is clickable if it really isn't going to do anything.

cc @yuanLeeMidori.

@humphd humphd added type: enhancement New feature or request area: front-end area: css styling Anything related to CSS styling labels Nov 18, 2020
@yuanLeeMidori yuanLeeMidori self-assigned this Nov 18, 2020
@yuanLeeMidori
Copy link
Contributor

I tried to calculate the length of the full title and compare it with the current length of title size in order to make the fullly-displayed ones non-clickable/non-expandable, but it didn't work. Alternatively, the title font size has been shrink so that the title will mostly be fully displayed. However, it is still good to have the feature that can distinguish between the expandable ones and the non-expandable ones.

Related PR: #2006

@yuanLeeMidori yuanLeeMidori removed their assignment Jul 12, 2021
@aserputov aserputov added the 5 min fix Fixable in 5 minutes or less label Feb 24, 2022
@aserputov
Copy link
Contributor

@humphd can we close this one ?

@cindyorangis
Copy link
Contributor

Hahaha, this is the old Gatsby UI! What a sight

@humphd
Copy link
Contributor Author

humphd commented Feb 24, 2022

This is still happening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5 min fix Fixable in 5 minutes or less area: css styling Anything related to CSS styling area: front-end type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants