Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue rendering signup form #9

Closed
toniher opened this issue Feb 3, 2015 · 6 comments
Closed

Issue rendering signup form #9

toniher opened this issue Feb 3, 2015 · 6 comments

Comments

@toniher
Copy link
Member

toniher commented Feb 3, 2015

In UserFieldsCreateTemplate.php execute method the following code:

            if ( !$this->haveData( 'header' ) ) {
                  return '';
            }

prevents form to be drawn.
If commented, everything OK. However, I noticed that Javascript checks (such as mandatory acting on empty fields) do not seem to work, so something should be included to make it happen. Any idea is appreciated.

@mwjames
Copy link
Contributor

mwjames commented Feb 3, 2015

Maybe try @$this->haveData( 'header' ) === false in order to prevent $this->html( 'header' ) from accessing a non-existing header.

I noticed that Javascript checks (such as mandatory acting on empty fields) do not seem to work, so something should be included to make it happen. Any idea is

JavaScript from SF? Try loading/register the SF resourcemodule with this template. (maybe something like $this->getSkin()->getOutput()->addModules( ... );

@toniher
Copy link
Member Author

toniher commented Feb 3, 2015

Sorry not reading fully your comment first. I just submitted pull request #10. I cannot access Skin object from $this, so I had to use global $wgOut :/. I removed header reference as well.

@mwjames
Copy link
Contributor

mwjames commented Feb 3, 2015

Once you get this rolling maybe you could make one or two screen-dumps (see SG or SIL) as it will be easier for users to actually anticipate what this extension can do.

@toniher
Copy link
Member Author

toniher commented Feb 4, 2015

No problem. Right now extension is a bit spartan, and a next step would be offering a better look and options such as 'password by email' (as it's the case with default signup)

semantic-signup

@mwjames
Copy link
Contributor

mwjames commented Feb 6, 2015

The screen-dump has been added to smw.org@SES

Right now extension is a bit spartan, and a next step would be offering a better look and options such as 'password by email' (as it's the case with default signup)

Maybe it is best to convert those items into follow-ups.

@mwjames mwjames closed this as completed Feb 6, 2015
@kghbln
Copy link
Member

kghbln commented Feb 12, 2015

follow-up for "password by email": see issue #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants