[Modal] - sets body height when modal can't fit but does not set it back when modal closes

[startswithaj]

          screenHeight: function() {
            if( module.can.fit() ) {
              $body.css('height', '');
            }
            else {
              module.debug('Modal is taller than page content, resizing page height');
              $body
                .css('height', module.cache.height + (settings.padding * 2) )
              ;
            }
          },

This code runs on modal.show
but no code sets the body height back to '' when the modal closes

repro:

have modal thats bigger than body, show modal, close modal. Height still set on body.

[jlukic]

It was set to leave it in place I dont recall why but I'm fairly certain it can safely be removed.

[startswithaj]

Yeah I just call body.css height, '' when I hide the modal and haven't seen anything untoward.

On 11 Jul 2015, at 2:12 am, Jack Lukic notifications@github.com wrote:

It was set to leave it in place I dont recall why but I'm fairly certain it can safely be removed.

—
Reply to this email directly or view it on GitHub.

[iLavs]

i have the issue with performance of simple modal window. my code look like here: https://ng-semantic.herokuapp.com/#/elements/modal , first exmpl,

but Modal doesn't work correctly. Can someone help me with it?

[abomusab]

I solved the problem by adding

.modal {
        bottom: auto;

    }

to your page

[lackneets]

.modal { bottom: auto; }

Solved too. Seems like Bootstrap conflicts with Semantic modal