Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search: preventing event bubbling leading to unexpected behaviour #3118

Open
achanta3215 opened this issue Aug 29, 2018 · 7 comments
Open

Search: preventing event bubbling leading to unexpected behaviour #3118

achanta3215 opened this issue Aug 29, 2018 · 7 comments

Comments

@achanta3215
Copy link

achanta3215 commented Aug 29, 2018

Bug Report

Steps

Render any other component which is normally expected to close when clicked outside (e.g. Popup)
Click on Search component
The other component (e.g. Popup) does not close on clicking on Search component

Expected Result

Other components (e.g Popup) that rely on window onclick listener to close when clicked outside its area must be able to close

Actual Result

Search component prevents event bubbling and other components (e.g Popup) are not closed when clicking on Search component

Version

0.82.3

Testcase

CodeSandbox to replicate the issue

@welcome
Copy link

welcome bot commented Aug 29, 2018

👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you've completed all the fields in the issue template so we can best help.

We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can.

@layershifter
Copy link
Member

The testcase doesn't match the issue description, please add more clarification to the issue.

I will reopen it when will receive a reply.

@achanta3215
Copy link
Author

@layershifter Reverted unintended changes on the same codesandbox. It now points to the correct example. Thanks.

@layershifter
Copy link
Member

Cool, thank you! 👍

@layershifter layershifter changed the title Search component preventing event bubbling leading to unexpected behaviour integrating with other components Search: preventing event bubbling leading to unexpected behaviour Aug 31, 2018
@layershifter layershifter added bug and removed invalid labels Aug 31, 2018
@stale
Copy link

stale bot commented Feb 27, 2019

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Feb 27, 2019
@achanta3215
Copy link
Author

Cool, thank you! 👍

Issue seems to be fixed in 0.83.0. Reference to forked codesandbox.

@stale stale bot removed the stale label Jun 4, 2019
@stale
Copy link

stale bot commented Dec 1, 2019

There has been no activity in this thread for 180 days. While we care about every issue and we’d love to see this fixed, the core team’s time is limited so we have to focus our attention on the issues that are most pressing. Therefore, we will likely not be able to get to this one.

However, PRs for this issue will of course be accepted and welcome!

If there is no more activity in the next 180 days, this issue will be closed automatically for housekeeping. To prevent this, simply leave a reply here. Thanks!

@stale stale bot added the stale label Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants