Skip to content

chore(deps): update dependency rubocop to v1.66.0 #1916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 31, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop (source, changelog) 1.65.1 -> 1.66.0 age adoption passing confidence

Release Notes

rubocop/rubocop (rubocop)

v1.66.0

Compare Source

New features
  • #​13077: Add new global StringLiteralsFrozenByDefault option for correct analysis with RUBYOPT=--enable=frozen-string-literal. ([@​earlopain][])
  • #​13080: Add new DocumentationExtension global option to serve documentation with extensions different than .html. ([@​earlopain][])
  • #​13074: Add new Lint/UselessNumericOperation cop to check for inconsequential numeric operations. ([@​zopolis4][])
  • #​13061: Add new Style/RedundantInterpolationUnfreeze cop to check for dup and @+ on interpolated strings in Ruby >= 3.0. ([@​earlopain][])
Bug fixes
  • #​13093: Fix an error for Lint/ImplicitStringConcatenation when implicitly concatenating a string literal with a line break and string interpolation. ([@​koic][])
  • #​13098: Fix an error for Style/IdenticalConditionalBranches when handling empty case branches. ([@​koic][])
  • #​13113: Fix an error for Style/IfWithSemicolon when a nested if with a semicolon is used. ([@​koic][])
  • #​13097: Fix an error for Style/InPatternThen when using alternative pattern matching deeply. ([@​koic][])
  • #​13159: Fix an error for Style/OneLineConditional when using if/then/else/end with multiple expressions in the then body. ([@​koic][])
  • #​13092: Fix an incorrect autocorrect for Layout/EmptyLineBetweenDefs when two method definitions are on the same line separated by a semicolon. ([@​koic][])
  • #​13116: Fix an incorrect autocorrect for Style/IfWithSemicolon when a single-line if/;/end has an argument in the then body expression. ([@​koic][])
  • #​13161: Fix incorrect autocorrect for Style/IfWithSemicolon when using multiple expressions in the else body. ([@​koic][])
  • #​13132: Fix incorrect autocorrect for Style/TrailingBodyOnMethodDefinition when an expression precedes a method definition on the same line with a semicolon. ([@​koic][])
  • #​13164: Fix incorrect autocorrect behavior for Layout/BlockAlignment when EnforcedStyleAlignWith: either (default). ([@​koic][])
  • #​13087: Fix an incorrect autocorrect for Style/MultipleComparison when expression with more comparisons precedes an expression with less comparisons. ([@​fatkodima][])
  • #​13172: Fix an error for Layout/EmptyLinesAroundExceptionHandlingKeywords when ensure or else and end are on the same line. ([@​koic][])
  • #​13107: Fix an error for Lint/ImplicitStringConcatenation when there are multiple adjacent string interpolation literals on the same line. ([@​koic][])
  • #​13111: Fix an error for Style/GuardClause when if clause is empty and correction would not fit on single line because of Layout/LineLength. ([@​earlopain][])
  • #​13137: Fix an error for Style/ParallelAssignment when using __FILE__. ([@​earlopain][])
  • #​13143: Fix an error during TargetRubyVersion detection if the gemspec is not valid syntax. ([@​earlopain][])
  • #​13131: Fix false negatives for Lint/Void when using ensure, defs and numblock. ([@​vlad-pisanov][])
  • #​13174: Fix false negatives for Style/MapIntoArray when initializing the destination using Array[], Array([]), or Array.new([]). ([@​vlad-pisanov][])
  • #​13173: Fix false negatives for Style/EmptyLiteral when using Array[], Hash[], Array.new([]) and Hash.new([]). ([@​vlad-pisanov][])
  • #​13126: Fix a false positive for Style/Alias when using multiple alias in def. ([@​koic][])
  • #​13085: Fix a false positive for Style/EmptyElse when a comment-only else is used after elsif and AllowComments: true is set. ([@​koic][])
  • #​13118: Fix a false positive for Style/MapIntoArray when splatting. ([@​earlopain][])
  • #​13105: Fix false positives for Style/ArgumentsForwarding when forwarding kwargs/block arg with non-matching additional args. ([@​koic][])
  • #​13139: Fix false positives for Style/RedundantCondition when using modifier if or unless. ([@​koic][])
  • #​13134: Fix false negative for Lint/Void when using using frozen literals. ([@​vlad-pisanov][])
  • #​13148: Fix incorrect autocorrect for Lint/EmptyConditionalBody when missing elsif body with end on the same line. ([@​koic][])
  • #​13109: Fix an error for the Lockfile parser when it contains incompatible BUNDLED WITH versions. ([@​earlopain][])
  • #​13112: Fix detection of TargetRubyVersion through the gemfile if the gemfile ruby version is below 2.7. ([@​earlopain][])
  • #​13155: Fixes an error when the server cache directory has too long path, causing rubocop to fail even with caching disabled. ([@​protocol7][])
Changes
  • #​13050: Allow get_!, set_!, get_?, set_?, get_=, and set_= in Naming/AccessorMethodName. ([@​koic][])
  • #​13103: Make Lint/UselessAssignment autocorrection safe. ([@​koic][])
  • #​13099: Make Style/RedundantRegexpArgument respect the EnforcedStyle of Style/StringLiterals. ([@​koic][])
  • #​13165: Remove dependency on the rexml gem. ([@​bquorning][])
  • #​13090: Require RuboCop AST 1.32.0+ to use RuboCop::AST::RationalNode. ([@​koic][])

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

netlify bot commented Aug 31, 2024

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit 84b9569
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/66d86b836aa7a600088987e0
😎 Deploy Preview https://deploy-preview-1916--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor Author

renovate bot commented Sep 2, 2024

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

Copy link
Contributor

qodo-merge-pro bot commented Sep 2, 2024

CI Failure Feedback 🧐

Action: tests (macos, nightly)

Failed stage: Run tests [❌]

Failed test name: Remote WebDriver starts remotely

Failure summary:

The action failed due to multiple errors in the Remote WebDriver tests. Specifically:

  • The tests Remote WebDriver starts remotely, Remote WebDriver uploads, and Remote WebDriver downloads
    all encountered a TypeError.
  • The error no implicit conversion of String into Integer occurred in the method Selenium::Server.get.
  • This error suggests that there is an issue with the arguments being passed to the
    Selenium::Server.get method, where a string is being used where an integer is expected.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  macOS
    ...
    
    285:  timeout_minutes: 20
    286:  max_attempts: 3
    287:  command: cd examples/ruby
    288:  bundle exec rspec
    289:  
    290:  retry_wait_seconds: 10
    291:  polling_interval_seconds: 1
    292:  warning_on_retry: true
    293:  continue_on_error: false
    ...
    
    298:  PATH: /Users/runner/.local/bin:/opt/homebrew/bin:/opt/homebrew/sbin:/Users/runner/.cargo/bin:/usr/local/opt/curl/bin:/usr/local/bin:/usr/local/sbin:/Users/runner/bin:/Users/runner/.yarn/bin:/Users/runner/Library/Android/sdk/tools:/Users/runner/Library/Android/sdk/platform-tools:/Library/Frameworks/Python.framework/Versions/Current/bin:/Library/Frameworks/Mono.framework/Versions/Current/Commands:/usr/bin:/bin:/usr/sbin:/sbin:/Users/runner/.dotnet/tools
    299:  JAVA_HOME: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.24-8/arm64/Contents/Home
    300:  JAVA_HOME_11_ARM64: /Users/runner/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.24-8/arm64/Contents/Home
    301:  ##[endgroup]
    302:  ......*.........................................................................***...*************...*.....*........*FFF....*******..........**************.............................
    303:  Pending: (Failures listed here are expected and do not affect your suite's status)
    304:  1) Keys copy and paste
    305:  # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    306:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    ...
    
    425:  40) Element Locators with relative locators finds near element
    426:  # These are reference following the documentation example
    427:  # ./spec/elements/locators_spec.rb:55
    428:  41) Element Locators with relative locators chains relative locators
    429:  # These are reference following the documentation example
    430:  # ./spec/elements/locators_spec.rb:59
    431:  Failures:
    432:  1) Remote WebDriver starts remotely
    433:  Got 0 failures and 2 other errors:
    434:  1.1) Failure/Error:
    435:  Selenium::Server.get(:latest,
    436:  background: true,
    437:  args: %w[--selenium-manager true --enable-managed-downloads true])
    438:  TypeError:
    439:  no implicit conversion of String into Integer
    440:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    441:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    442:  1.2) Failure/Error:
    443:  Selenium::Server.get(:latest,
    444:  background: true,
    445:  args: %w[--selenium-manager true --enable-managed-downloads true])
    446:  TypeError:
    447:  no implicit conversion of String into Integer
    448:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    449:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    450:  2) Remote WebDriver uploads
    451:  Got 0 failures and 2 other errors:
    452:  2.1) Failure/Error:
    453:  Selenium::Server.get(:latest,
    454:  background: true,
    455:  args: %w[--selenium-manager true --enable-managed-downloads true])
    456:  TypeError:
    457:  no implicit conversion of String into Integer
    458:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    459:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    460:  2.2) Failure/Error:
    461:  Selenium::Server.get(:latest,
    462:  background: true,
    463:  args: %w[--selenium-manager true --enable-managed-downloads true])
    464:  TypeError:
    465:  no implicit conversion of String into Integer
    466:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    467:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    468:  3) Remote WebDriver downloads
    469:  Got 0 failures and 2 other errors:
    470:  3.1) Failure/Error:
    471:  Selenium::Server.get(:latest,
    472:  background: true,
    473:  args: %w[--selenium-manager true --enable-managed-downloads true])
    474:  TypeError:
    475:  no implicit conversion of String into Integer
    476:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    477:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    478:  3.2) Failure/Error:
    479:  Selenium::Server.get(:latest,
    480:  background: true,
    481:  args: %w[--selenium-manager true --enable-managed-downloads true])
    482:  TypeError:
    483:  no implicit conversion of String into Integer
    484:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    485:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    486:  Finished in 6 minutes 6 seconds (files took 5.42 seconds to load)
    487:  185 examples, 3 failures, 41 pending
    488:  Failed examples:
    489:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
    490:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
    491:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
    492:  ##[warning]Attempt 1 failed. Reason: Child_process exited with error code 1
    493:  ......*.........................................................................***...*************...*.....*........*FFF....*******..........**************.............................
    494:  Pending: (Failures listed here are expected and do not affect your suite's status)
    495:  1) Keys copy and paste
    496:  # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    497:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    ...
    
    616:  40) Element Locators with relative locators finds near element
    617:  # These are reference following the documentation example
    618:  # ./spec/elements/locators_spec.rb:55
    619:  41) Element Locators with relative locators chains relative locators
    620:  # These are reference following the documentation example
    621:  # ./spec/elements/locators_spec.rb:59
    622:  Failures:
    623:  1) Remote WebDriver starts remotely
    624:  Got 0 failures and 2 other errors:
    625:  1.1) Failure/Error:
    626:  Selenium::Server.get(:latest,
    627:  background: true,
    628:  args: %w[--selenium-manager true --enable-managed-downloads true])
    629:  TypeError:
    630:  no implicit conversion of String into Integer
    631:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    632:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    633:  1.2) Failure/Error:
    634:  Selenium::Server.get(:latest,
    635:  background: true,
    636:  args: %w[--selenium-manager true --enable-managed-downloads true])
    637:  TypeError:
    638:  no implicit conversion of String into Integer
    639:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    640:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    641:  2) Remote WebDriver uploads
    642:  Got 0 failures and 2 other errors:
    643:  2.1) Failure/Error:
    644:  Selenium::Server.get(:latest,
    645:  background: true,
    646:  args: %w[--selenium-manager true --enable-managed-downloads true])
    647:  TypeError:
    648:  no implicit conversion of String into Integer
    649:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    650:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    651:  2.2) Failure/Error:
    652:  Selenium::Server.get(:latest,
    653:  background: true,
    654:  args: %w[--selenium-manager true --enable-managed-downloads true])
    655:  TypeError:
    656:  no implicit conversion of String into Integer
    657:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    658:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    659:  3) Remote WebDriver downloads
    660:  Got 0 failures and 2 other errors:
    661:  3.1) Failure/Error:
    662:  Selenium::Server.get(:latest,
    663:  background: true,
    664:  args: %w[--selenium-manager true --enable-managed-downloads true])
    665:  TypeError:
    666:  no implicit conversion of String into Integer
    667:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    668:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    669:  3.2) Failure/Error:
    670:  Selenium::Server.get(:latest,
    671:  background: true,
    672:  args: %w[--selenium-manager true --enable-managed-downloads true])
    673:  TypeError:
    674:  no implicit conversion of String into Integer
    675:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    676:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    677:  Finished in 6 minutes 5 seconds (files took 3.33 seconds to load)
    678:  185 examples, 3 failures, 41 pending
    679:  Failed examples:
    680:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
    681:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
    682:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
    683:  ##[warning]Attempt 2 failed. Reason: Child_process exited with error code 1
    684:  ......*.........................................................................***...*************...*.....*........*FFF....*******..........**************.............................
    685:  Pending: (Failures listed here are expected and do not affect your suite's status)
    686:  1) Keys copy and paste
    687:  # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    688:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    ...
    
    807:  40) Element Locators with relative locators finds near element
    808:  # These are reference following the documentation example
    809:  # ./spec/elements/locators_spec.rb:55
    810:  41) Element Locators with relative locators chains relative locators
    811:  # These are reference following the documentation example
    812:  # ./spec/elements/locators_spec.rb:59
    813:  Failures:
    814:  1) Remote WebDriver starts remotely
    815:  Got 0 failures and 2 other errors:
    816:  1.1) Failure/Error:
    817:  Selenium::Server.get(:latest,
    818:  background: true,
    819:  args: %w[--selenium-manager true --enable-managed-downloads true])
    820:  TypeError:
    821:  no implicit conversion of String into Integer
    822:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    823:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    824:  1.2) Failure/Error:
    825:  Selenium::Server.get(:latest,
    826:  background: true,
    827:  args: %w[--selenium-manager true --enable-managed-downloads true])
    828:  TypeError:
    829:  no implicit conversion of String into Integer
    830:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    831:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    832:  2) Remote WebDriver uploads
    833:  Got 0 failures and 2 other errors:
    834:  2.1) Failure/Error:
    835:  Selenium::Server.get(:latest,
    836:  background: true,
    837:  args: %w[--selenium-manager true --enable-managed-downloads true])
    838:  TypeError:
    839:  no implicit conversion of String into Integer
    840:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    841:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    842:  2.2) Failure/Error:
    843:  Selenium::Server.get(:latest,
    844:  background: true,
    845:  args: %w[--selenium-manager true --enable-managed-downloads true])
    846:  TypeError:
    847:  no implicit conversion of String into Integer
    848:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    849:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    850:  3) Remote WebDriver downloads
    851:  Got 0 failures and 2 other errors:
    852:  3.1) Failure/Error:
    853:  Selenium::Server.get(:latest,
    854:  background: true,
    855:  args: %w[--selenium-manager true --enable-managed-downloads true])
    856:  TypeError:
    857:  no implicit conversion of String into Integer
    858:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    859:  # ./spec/drivers/remote_webdriver_spec.rb:16:in `block (2 levels) in <top (required)>'
    860:  3.2) Failure/Error:
    861:  Selenium::Server.get(:latest,
    862:  background: true,
    863:  args: %w[--selenium-manager true --enable-managed-downloads true])
    864:  TypeError:
    865:  no implicit conversion of String into Integer
    866:  # ./spec/drivers/remote_webdriver_spec.rb:10:in `block (2 levels) in <top (required)>'
    867:  # ./spec/drivers/remote_webdriver_spec.rb:17:in `block (2 levels) in <top (required)>'
    868:  Finished in 5 minutes 3 seconds (files took 1.94 seconds to load)
    869:  185 examples, 3 failures, 41 pending
    870:  Failed examples:
    871:  rspec ./spec/drivers/remote_webdriver_spec.rb:19 # Remote WebDriver starts remotely
    872:  rspec ./spec/drivers/remote_webdriver_spec.rb:26 # Remote WebDriver uploads
    873:  rspec ./spec/drivers/remote_webdriver_spec.rb:42 # Remote WebDriver downloads
    874:  ##[error]Final attempt failed. Child_process exited with error code 1
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    @harsha509 harsha509 merged commit a2c0c84 into trunk Sep 4, 2024
    12 checks passed
    @harsha509 harsha509 deleted the renovate/rubocop-1.x-lockfile branch September 4, 2024 17:26
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    1 participant