-
-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[dotnet] Align CS projects name to understand the editing context #15843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Conversation
Thank you, @nvborisenko for this code suggestion. The support packages contain example code that many users find helpful, but they do not necessarily represent We actively encourage people to add the wrapper and helper code that makes sense for them to their own frameworks. |
PR Reviewer Guide 🔍(Review updated until commit fea13ba)Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
TODO: review post usage like release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wouldn't people need to change the dependencies in their code from this? Maybe we could make this change for 5.0, but even then we'd end up stranding a lot of people who don't really pay attention, and even if it makes the name more clear, I don't think it is worth that outcome. |
No impact for end users, fully backward compatible. It is only about us, for maintainers. These changes reflect the project structure better. When I have many IDE instances opened, now I can easily understand what project links to nuget package. Probably the name is longer, but it is really better (at least 2 people agreed from .NET world independently, see related issue). |
User description
🔗 Related Issues
Resolves #15823
💥 What does this PR do?
Adjust naming in .NET to understand what I am editing.
🔧 Implementation Notes
💡 Additional Considerations
🔄 Types of changes
PR Type
Enhancement
Description
Renamed .NET solution and project files for clarity
WebDriver.csproj
toSelenium.WebDriver.csproj
WebDriver.Support.csproj
toSelenium.WebDriver.Support.csproj
Updated project references and solution file to match new names
Added and updated .nuspec files for renamed projects
Cleaned up and standardized test project files and references
Changes walkthrough 📝
18 files
Update solution to reference renamed project files
Update support project reference to new WebDriver name
Update reference to renamed WebDriver project
Add renamed Chrome test project file
Remove old Chrome test project file
Add NUnit config for renamed Chrome tests
Update Edge test project to use new references
Add NUnit config for renamed Edge tests
Update Firefox test project to use new references
Add NUnit config for renamed Firefox tests
Update IE test project to use new references
Add NUnit config for renamed IE tests
Update Remote test project to use new references
Add NUnit config for renamed Remote tests
Update Safari test project to use new references
Add NUnit config for renamed Safari tests
Update Support test project to use new references
Add NUnit config for renamed Support tests
5 files
Add renamed main WebDriver project file
Add nuspec for renamed WebDriver package
Add nuspec for strong-named WebDriver package
Add nuspec for renamed Support package
Add nuspec for strong-named Support package
1 files