-
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[dotnet] Add nullability to Chromium configuration types #15204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Add nullability to Chromium configuration types #15204
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Add nullability to Chromium configuration types
Motivation and Context
Contributes to #14640
Types of changes
Checklist
PR Type
Enhancement
Description
Enabled nullable reference types in Chromium-related classes.
Simplified property declarations and removed backing fields.
Improved exception handling and validation logic.
Enhanced code readability and maintainability.
Changes walkthrough 📝
ChromiumAndroidOptions.cs
Refactored ChromiumAndroidOptions with nullable typesdotnet/src/webdriver/Chromium/ChromiumAndroidOptions.cs
AndroidProcessnullable.ChromiumMobileEmulationDeviceSettings.cs
Refactored ChromiumMobileEmulationDeviceSettings with nullable typesdotnet/src/webdriver/Chromium/ChromiumMobileEmulationDeviceSettings.cs
UserAgentnullable.EnableTouchEvents.ChromiumNetworkConditions.cs
Refactored ChromiumNetworkConditions with nullable typesdotnet/src/webdriver/Chromium/ChromiumNetworkConditions.cs
ChromiumPerformanceLoggingPreferences.cs
Refactored ChromiumPerformanceLoggingPreferences with nullable typesdotnet/src/webdriver/Chromium/ChromiumPerformanceLoggingPreferences.cs