-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[java] use the java process builder to run external processes #12898
Conversation
13cab26
to
2877334
Compare
Codecov ReportAll modified lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## trunk #12898 +/- ##
=======================================
Coverage 56.51% 56.51%
=======================================
Files 86 86
Lines 5255 5255
Branches 187 187
=======================================
Hits 2970 2970
Misses 2098 2098
Partials 187 187 ☔ View full report in Codecov by Sentry. |
2877334
to
e6f4346
Compare
Oh shoot, I was going to merge this before 4.14. :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @joerg1985!
@mykola-mokhnach @SrinivasanTarget @valfirst, does this affect Appium?
yes it does: appium/java-client#2036 (comment) That is why I have requested this feature |
OK, so you are already checking this. We should be able to merge this anytime, @joerg1985. |
@mykola-mokhnach it seems you mixed up PRs, this one about process management @diemol it affects Appium, but I'm not sure how much, anyway once SNAPSHOT is published, it can be tested |
Description
Replaced commons-exec with the java process builder to get rid of the dependency.
Motivation and Context
With Java 11 we now have all we need to implement the same functionality without a dependency.
Types of changes
Checklist