Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Allow Selenium Manager to use mirror URL without reproducing existing JSON formats #13519

Open
titusfortner opened this issue Jan 28, 2024 · 2 comments
Labels
C-rust help wanted Issues looking for contributions I-enhancement

Comments

@titusfortner
Copy link
Member

Feature and motivation

Allow specifying a URL with a specific file structure, or allow providing a json template to use rather than needing to copy the browser vendor's more complicated JSON schema.

This is a follow-on to #13460 and is a valid feature, but the Selenium team is unlikely to prioritize this.

Usage example

https://github.com/giggio/node-chromedriver/blob/120.0.2/install.js#L131

or create a custom schema in toml file or in same directory that Selenium Manager would use to know how to parse the file at the provided URL.

@titusfortner titusfortner added I-enhancement help wanted Issues looking for contributions C-rust labels Jan 28, 2024
Copy link

This issue is looking for contributors.

Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested.

@gerelef
Copy link

gerelef commented Jul 27, 2024

This is a very legitimate solution in terms of how to handle mirrors.
As an alternative to this. to avoid having to create a schema for every mirror, (beware, evil hack incoming), couldn't we try to match (from whatever response schema and/or format we get - it wouldn't matter) the download URL according to the filename via regex?
This is, of-course, a terrible and evil hack, but I'd assume this would support most - if not all - use-cases for this feature.

Edit: The reason for this alternative proposal, is the fact that the original solution would probably be too much effort to actually implement.
We'd have to somehow match arbitrary schemas to JSON path's metadata essentially.
This is highly non-trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-rust help wanted Issues looking for contributions I-enhancement
Projects
None yet
Development

No branches or pull requests

2 participants