Skip to content

Commit 4dab85c

Browse files
authored
[java][BiDi] enable Edge BiDi tests for network module (#15661)
[java] enable Edge BiDi tests for network module
1 parent f7aa586 commit 4dab85c

File tree

4 files changed

+1
-13
lines changed

4 files changed

+1
-13
lines changed

java/test/org/openqa/selenium/bidi/network/AddInterceptParametersTest.java

-8
Original file line numberDiff line numberDiff line change
@@ -18,20 +18,17 @@
1818
package org.openqa.selenium.bidi.network;
1919

2020
import static org.assertj.core.api.AssertionsForClassTypes.assertThat;
21-
import static org.openqa.selenium.testing.drivers.Browser.EDGE;
2221

2322
import java.util.List;
2423
import org.junit.jupiter.api.Test;
2524
import org.openqa.selenium.bidi.module.Network;
2625
import org.openqa.selenium.testing.JupiterTestBase;
2726
import org.openqa.selenium.testing.NeedsFreshDriver;
28-
import org.openqa.selenium.testing.NotYetImplemented;
2927

3028
class AddInterceptParametersTest extends JupiterTestBase {
3129

3230
@Test
3331
@NeedsFreshDriver
34-
@NotYetImplemented(EDGE)
3532
void canAddInterceptPhase() {
3633
try (Network network = new Network(driver)) {
3734
String intercept =
@@ -42,7 +39,6 @@ void canAddInterceptPhase() {
4239

4340
@Test
4441
@NeedsFreshDriver
45-
@NotYetImplemented(EDGE)
4642
void canAddInterceptPhases() {
4743
try (Network network = new Network(driver)) {
4844
String intercept =
@@ -55,7 +51,6 @@ void canAddInterceptPhases() {
5551

5652
@Test
5753
@NeedsFreshDriver
58-
@NotYetImplemented(EDGE)
5954
void canAddStringUrlPattern() {
6055
try (Network network = new Network(driver)) {
6156
String intercept =
@@ -68,7 +63,6 @@ void canAddStringUrlPattern() {
6863

6964
@Test
7065
@NeedsFreshDriver
71-
@NotYetImplemented(EDGE)
7266
void canAddStringUrlPatterns() {
7367
try (Network network = new Network(driver)) {
7468
String intercept =
@@ -84,7 +78,6 @@ void canAddStringUrlPatterns() {
8478

8579
@Test
8680
@NeedsFreshDriver
87-
@NotYetImplemented(EDGE)
8881
void canAddUrlPattern() {
8982
try (Network network = new Network(driver)) {
9083
UrlPattern pattern =
@@ -104,7 +97,6 @@ void canAddUrlPattern() {
10497

10598
@Test
10699
@NeedsFreshDriver
107-
@NotYetImplemented(EDGE)
108100
void canAddUrlPatterns() {
109101
try (Network network = new Network(driver)) {
110102
UrlPattern pattern1 =

java/test/org/openqa/selenium/bidi/network/BUILD.bazel

+1
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ java_selenium_test_suite(
88
browsers = [
99
"firefox",
1010
"chrome",
11+
"edge",
1112
],
1213
tags = [
1314
"selenium-remote",

java/test/org/openqa/selenium/bidi/network/NetworkCommandsTest.java

-1
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ void canAddIntercept() {
5757

5858
@Test
5959
@NeedsFreshDriver
60-
@NotYetImplemented(EDGE)
6160
void canContinueRequest() throws InterruptedException {
6261
try (Network network = new Network(driver)) {
6362
String intercept =

java/test/org/openqa/selenium/bidi/network/NetworkEventsTest.java

-4
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ class NetworkEventsTest extends JupiterTestBase {
3939

4040
@Test
4141
@NeedsFreshDriver
42-
@NotYetImplemented(EDGE)
4342
void canListenToBeforeRequestSentEvent()
4443
throws ExecutionException, InterruptedException, TimeoutException {
4544
try (Network network = new Network(driver)) {
@@ -60,7 +59,6 @@ void canListenToBeforeRequestSentEvent()
6059

6160
@Test
6261
@NeedsFreshDriver
63-
@NotYetImplemented(EDGE)
6462
void canListenToResponseStartedEvent()
6563
throws ExecutionException, InterruptedException, TimeoutException {
6664
try (Network network = new Network(driver)) {
@@ -83,7 +81,6 @@ void canListenToResponseStartedEvent()
8381

8482
@Test
8583
@NeedsFreshDriver
86-
@NotYetImplemented(EDGE)
8784
void canListenToResponseCompletedEvent()
8885
throws ExecutionException, InterruptedException, TimeoutException {
8986
try (Network network = new Network(driver)) {
@@ -106,7 +103,6 @@ void canListenToResponseCompletedEvent()
106103

107104
@Test
108105
@NeedsFreshDriver
109-
@NotYetImplemented(EDGE)
110106
void canListenToResponseCompletedEventWithCookie()
111107
throws ExecutionException, InterruptedException, TimeoutException {
112108
try (Network network = new Network(driver)) {

0 commit comments

Comments
 (0)