[dotnet] Unwrap element wrapper recursively (#15362)

* [dotnet] Unwrap element wrapper more than once

* fix whitespace

Author: RenderMichael

dotnet/src/webdriver/Interactions/PointerInputDevice.cs

@@ -595,15 +595,21 @@ private Dictionary<string, object> ConvertElement()
             if (elementReference == null)
             {
                 IWrapsElement? elementWrapper = this.target as IWrapsElement;
-                if (elementWrapper != null)
+                while (elementWrapper != null)
                 {
                     elementReference = elementWrapper.WrappedElement as IWebDriverObjectReference;
+                    if (ReferenceEquals(elementWrapper, elementWrapper.WrappedElement))
+                    {
+                        throw new InvalidOperationException("Cannot determine root element: element wrapper wraps itself");
+                    }
+
+                    elementWrapper = elementWrapper.WrappedElement as IWrapsElement;
                 }
             }
 
             if (elementReference == null)
             {
-                throw new ArgumentException("Target element cannot be converted to IWebElementReference");
+                throw new ArgumentException($"Target element cannot be converted to {nameof(IWebDriverObjectReference)}");
             }
 
             Dictionary<string, object> elementDictionary = elementReference.ToDictionary();

dotnet/src/webdriver/Interactions/WheelInputDevice.cs

@@ -211,15 +211,21 @@ private Dictionary<string, object> ConvertElement()
             if (elementReference == null)
             {
                 IWrapsElement? elementWrapper = this.target as IWrapsElement;
-                if (elementWrapper != null)
+                while (elementWrapper != null)
                 {
                     elementReference = elementWrapper.WrappedElement as IWebDriverObjectReference;
+                    if (ReferenceEquals(elementWrapper, elementWrapper.WrappedElement))
+                    {
+                        throw new InvalidOperationException("Cannot determine root element: element wrapper wraps itself");
+                    }
+
+                    elementWrapper = elementWrapper.WrappedElement as IWrapsElement;
                 }
             }
 
             if (elementReference == null)
             {
-                throw new ArgumentException("Target element cannot be converted to IWebElementReference");
+                throw new ArgumentException($"Target element cannot be converted to {nameof(IWebDriverObjectReference)}");
             }
 
             Dictionary<string, object> elementDictionary = elementReference.ToDictionary();

dotnet/test/common/Interactions/BasicMouseInterfaceTest.cs

@@ -162,6 +162,24 @@ public void ShouldAllowMoveAndClick()
         Assert.That(toClick.GetAttribute("value"), Is.EqualTo("Clicked"), "Value should change to Clicked.");
     }
 
+    [Test]
+    [IgnoreBrowser(Browser.Remote, "API not implemented in driver")]
+    public void ShouldAllowMoveAndClickDoubleWrappedElement()
+    {
+        driver.Url = javascriptPage;
+
+        IWebElement toClick = driver.FindElement(By.Id("clickField"));
+
+        toClick = new WebElementWrapper(toClick);
+        toClick = new WebElementWrapper(toClick);
+
+        Actions actionProvider = new Actions(driver);
+        IAction contextClick = actionProvider.MoveToElement(toClick).Click().Build();
+
+        contextClick.Perform();
+        Assert.That(toClick.GetAttribute("value"), Is.EqualTo("Clicked"), "Value should change to Clicked.");
+    }
+
     [Test]
     [IgnoreBrowser(Browser.Chrome, "Not working properly in RBE, works locally with pinned browsers")]
     [IgnoreBrowser(Browser.Edge, "Not working properly in RBE, works locally with pinned browsers")]

dotnet/test/common/Interactions/BasicWheelInterfaceTest.cs

@@ -165,6 +165,23 @@ public void ShouldNotAllowScrollingWhenOriginOffsetIsOutOfViewport()
             Throws.InstanceOf<MoveTargetOutOfBoundsException>());
     }
 
+    [Test]
+    [IgnoreBrowser(Browser.Firefox, "Incorrectly throws out of bounds exception")]
+    public void ShouldAllowScrollingToADoubleWrappedElement()
+    {
+        driver.Url = scrollFrameOutOfViewport;
+        IWebElement iframe = driver.FindElement(By.TagName("iframe"));
+
+        Assert.That(IsInViewport(iframe), Is.False);
+
+        var wrappedFrame = new WebElementWrapper(iframe);
+        wrappedFrame = new WebElementWrapper(wrappedFrame);
+
+        new Actions(driver).ScrollToElement(wrappedFrame).Build().Perform();
+
+        Assert.That(IsInViewport(iframe), Is.True);
+    }
+
     private bool IsInViewport(IWebElement element)
     {
         String script =

dotnet/test/common/WebElementWrapper.cs

@@ -0,0 +1,105 @@
+// <copyright file="WebElementWrapper.cs" company="Selenium Committers">
+// Licensed to the Software Freedom Conservancy (SFC) under one
+// or more contributor license agreements.  See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership.  The SFC licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License.  You may obtain a copy of the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied.  See the License for the
+// specific language governing permissions and limitations
+// under the License.
+// </copyright>
+
+using System.Collections.ObjectModel;
+using System.Drawing;
+
+namespace OpenQA.Selenium
+{
+    public class WebElementWrapper : IWebElement, IWrapsElement
+    {
+        private readonly IWebElement _webElement;
+
+        public WebElementWrapper(IWebElement element)
+        {
+            _webElement = element;
+        }
+
+        public IWebElement WrappedElement => _webElement;
+
+        public string TagName => _webElement.TagName;
+
+        public string Text => _webElement.Text;
+
+        public bool Enabled => _webElement.Enabled;
+
+        public bool Selected => _webElement.Selected;
+
+        public Point Location => _webElement.Location;
+
+        public Size Size => _webElement.Size;
+
+        public bool Displayed => _webElement.Displayed;
+
+        public void Clear()
+        {
+            _webElement.Clear();
+        }
+
+        public void Click()
+        {
+            _webElement.Click();
+        }
+
+        public IWebElement FindElement(By by)
+        {
+            return _webElement.FindElement(by);
+        }
+
+        public ReadOnlyCollection<IWebElement> FindElements(By by)
+        {
+            return _webElement.FindElements(by);
+        }
+
+        public string GetAttribute(string attributeName)
+        {
+            return _webElement.GetAttribute(attributeName);
+        }
+
+        public string GetCssValue(string propertyName)
+        {
+            return _webElement.GetCssValue(propertyName);
+        }
+
+        public string GetDomAttribute(string attributeName)
+        {
+            return _webElement.GetDomAttribute(attributeName);
+        }
+
+        public string GetDomProperty(string propertyName)
+        {
+            return _webElement.GetDomProperty(propertyName);
+        }
+
+        public ISearchContext GetShadowRoot()
+        {
+            return _webElement.GetShadowRoot();
+        }
+
+        public void SendKeys(string text)
+        {
+            _webElement.SendKeys(text);
+        }
+
+        public void Submit()
+        {
+            _webElement.Submit();
+        }
+    }
+}