selenium 4.33.0

Author: rbri

pom.xml

@@ -5,7 +5,7 @@
 
     <groupId>org.seleniumhq.selenium</groupId>
     <artifactId>htmlunit3-driver</artifactId>
-    <version>4.32.0</version>
+    <version>4.33.0-SNAPSHOT</version>
 
     <name>${project.artifactId}</name>
     <description>WebDriver compatible driver for HtmlUnit headless browser</description>
@@ -18,8 +18,8 @@
         <maven.compiler.source>11</maven.compiler.source>
         <maven.compiler.target>11</maven.compiler.target>
 
-        <selenium.version>4.32.0</selenium.version>
-        <selenium.devtools.artifactId>selenium-devtools-v136</selenium.devtools.artifactId>
+        <selenium.version>4.33.0</selenium.version>
+        <selenium.devtools.artifactId>selenium-devtools-v137</selenium.devtools.artifactId>
         <htmlunit.version>4.12.0</htmlunit.version>
 
         <jetty.version>9.4.57.v20241219</jetty.version>

src/main/java/org/openqa/selenium/htmlunit/HtmlUnitTimeouts.java

@@ -18,7 +18,6 @@
 package org.openqa.selenium.htmlunit;
 
 import java.time.Duration;
-import java.util.concurrent.TimeUnit;
 
 import org.htmlunit.WebClient;
 import org.openqa.selenium.WebDriver;
@@ -40,37 +39,23 @@ public HtmlUnitTimeouts() {
     }
 
     public HtmlUnitTimeouts(final WebClient webClient) {
-        this.webClient_ = webClient;
+        webClient_ = webClient;
     }
 
     @Override
     public Duration getImplicitWaitTimeout() {
         return Duration.ofMillis(implicitWait_);
     }
 
-    @Deprecated
-    @Override
-    public WebDriver.Timeouts implicitlyWait(final long time, final TimeUnit unit) {
-        implicitlyWait(Duration.ofMillis(TimeUnit.MILLISECONDS.convert(time, unit)));
-        return this;
-    }
-
     @Override
     public WebDriver.Timeouts implicitlyWait(final Duration duration) {
-        this.implicitWait_ = Math.max(0, duration.toMillis());
+        implicitWait_ = Math.max(0, duration.toMillis());
         return this;
     }
 
     @Override
     public WebDriver.Timeouts scriptTimeout(final Duration duration) {
-        this.scriptTimeout_ = duration.toMillis();
-        return this;
-    }
-
-    @Deprecated
-    @Override
-    public WebDriver.Timeouts setScriptTimeout(final long time, final TimeUnit unit) {
-        scriptTimeout(Duration.ofMillis(TimeUnit.MILLISECONDS.convert(time, unit)));
+        scriptTimeout_ = duration.toMillis();
         return this;
     }
 
@@ -79,16 +64,9 @@ public Duration getScriptTimeout() {
         return Duration.ofMillis(scriptTimeout_);
     }
 
-    @Deprecated
-    @Override
-    public WebDriver.Timeouts pageLoadTimeout(final long time, final TimeUnit unit) {
-        pageLoadTimeout(Duration.ofMillis(TimeUnit.MILLISECONDS.convert(time, unit)));
-        return this;
-    }
-
     @Override
     public WebDriver.Timeouts pageLoadTimeout(final Duration duration) {
-        this.pageLoadTimeout_ = duration.toMillis();
+        pageLoadTimeout_ = duration.toMillis();
         setPageLoadTimeoutForWebClient(webClient_, pageLoadTimeout_);
         return this;
     }

src/test/java/org/openqa/selenium/htmlunit/WebDriverTestCase.java

@@ -101,7 +101,7 @@
 import org.openqa.selenium.chrome.ChromeDriverService;
 import org.openqa.selenium.chrome.ChromeOptions;
 import org.openqa.selenium.devtools.DevTools;
-import org.openqa.selenium.devtools.v136.emulation.Emulation;
+import org.openqa.selenium.devtools.v137.emulation.Emulation;
 import org.openqa.selenium.edge.EdgeDriver;
 import org.openqa.selenium.edge.EdgeDriverService;
 import org.openqa.selenium.edge.EdgeOptions;