-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Docker: Replace static value by env variable in Supervisord config #2762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
CI Feedback 🧐(Feedback updated until commit cc9b58f)A test triggered by this PR failed. Here is an AI-generated analysis of the failure:
|
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
User description
Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Motivation and Context
Types of changes
Checklist
PR Type
enhancement
Description
Replaced static password values with environment variables in
supervisord.conf
.Improved configurability and security for Supervisor configuration.
Changes walkthrough 📝
supervisord.conf
Use environment variables for Supervisor passwords
Base/supervisord.conf
password
values with environment variables.unix_http_server
andsupervisorctl
sections to use%(ENV_SE_SUPERVISORD_UNIX_SERVER_PASSWORD)s
.