Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document ERROR_TYPES in missing_optional_dependencies #577

Closed
mauicv opened this issue Jul 29, 2022 · 0 comments · Fixed by #580
Closed

Document ERROR_TYPES in missing_optional_dependencies #577

mauicv opened this issue Jul 29, 2022 · 0 comments · Fixed by #580
Assignees
@mauicv
Labels
Type: Maintenance Anything to do with library maintenance (CI, linting, refactoring etc.)

Comments

@mauicv
Copy link
Collaborator

mauicv commented Jul 29, 2022

Multiple naming conventions for libraries (ex torch and pytorch) lead to errors in the missing dependency work which are solved by ERROR_TYPES however ERROR_TYPES are not documented as for this usage leading to confusion. See this comment.
@mauicv mauicv added the Type: Bug Something isn't working label Jul 29, 2022
@mauicv mauicv self-assigned this Jul 29, 2022
This was referenced Jul 29, 2022
Merged
Merged
@ascillitoe ascillitoe linked a pull request Aug 10, 2022 that will close this issue
Fix minor Optional Dependency issues #580
Merged
@ascillitoe ascillitoe added Type: Maintenance Anything to do with library maintenance (CI, linting, refactoring etc.) and removed Type: Bug Something isn't working labels Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mauicv mauicv

Labels
Type: Maintenance Anything to do with library maintenance (CI, linting, refactoring etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix minor Optional Dependency issues mauicv/alibi-detect
2 participants
@mauicv @ascillitoe