From 22043542548801e9fe887aedc02643060a1d815b Mon Sep 17 00:00:00 2001
From: Sherif Akoush <sa@seldon.io>
Date: Mon, 17 Jan 2022 16:56:43 +0000
Subject: [PATCH] Sherif akoush/quickfix/fix alibi import test (#446)

* pin numpy < 1.22 (for alibi)

* reorder deps installation for tests
---
 runtimes/alibi-explain/requirements-dev.txt | 1 -
 runtimes/alibi-explain/setup.py             | 2 ++
 setup.cfg                                   | 8 ++++----
 3 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/runtimes/alibi-explain/requirements-dev.txt b/runtimes/alibi-explain/requirements-dev.txt
index 94a88f660..672b5dce1 100644
--- a/runtimes/alibi-explain/requirements-dev.txt
+++ b/runtimes/alibi-explain/requirements-dev.txt
@@ -1,3 +1,2 @@
-numpy
 nest_asyncio==1.5.4
 types-requests
diff --git a/runtimes/alibi-explain/setup.py b/runtimes/alibi-explain/setup.py
index f57a68836..afc580582 100644
--- a/runtimes/alibi-explain/setup.py
+++ b/runtimes/alibi-explain/setup.py
@@ -37,6 +37,8 @@ def _load_description() -> str:
         "mlserver",
         "alibi[shap]",
         "orjson",
+        # numba 0.55.0 requires: numpy <1.22 (for Shap / alibi)
+        "numpy<1.22",
     ],
     long_description=_load_description(),
     long_description_content_type="text/markdown",
diff --git a/setup.cfg b/setup.cfg
index 5e0eb57ba..d6b4fdf7e 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -67,21 +67,21 @@ commands = pytest {posargs} {toxinidir}/runtimes/mlflow
 
 [testenv:alibiexplain]
 deps =
-  -e{toxinidir}
   -e{toxinidir}/runtimes/alibi-explain
+  -e{toxinidir}
   -r{toxinidir}/requirements/dev.txt
   -r{toxinidir}/runtimes/alibi-explain/requirements-dev.txt
 commands = pytest {posargs} {toxinidir}/runtimes/alibi-explain
 
 [testenv:all-runtimes]
-deps = 
-  -e{toxinidir}[all]
+deps =
+  -e{toxinidir}/runtimes/alibi-explain
   -e{toxinidir}/runtimes/sklearn
   -e{toxinidir}/runtimes/xgboost
   -e{toxinidir}/runtimes/mllib
   -e{toxinidir}/runtimes/lightgbm
   -e{toxinidir}/runtimes/mlflow
-  -e{toxinidir}/runtimes/alibi-explain
+  -e{toxinidir}[all]
   -r{toxinidir}/requirements/dev.txt
   -r{toxinidir}/runtimes/mlflow/requirements-dev.txt
   -r{toxinidir}/runtimes/alibi-explain/requirements-dev.txt