Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XIAO SAMD21: Add TX/RX LED On/Off on Arduino IDE menu (like for Seeed Wio Terminal) #71

Open
dbstf opened this issue May 23, 2024 · 1 comment
Assignees
Labels
ArduinoCore-samd Label for ArduinoCore-samd UAY Unassigned yet

Comments

@dbstf
Copy link

dbstf commented May 23, 2024

Please add the compiler-flag option to enable/disable the Serial TX/RX LEDs also for the XIAO SAMD21 board, like you already did for the Seeed Wio Terminal by accepting commit c68cc757e623a4b30669e7880a4fb0224bbf6169

Add to boards.txt:
seeed_XIAO_m0.menu.txrxled.on=On
seeed_XIAO_m0.menu.txrxled.off=Off
seeed_XIAO_m0.menu.txrxled.on.build.flags.txrxled=-DTXRXLED_ENABLE

Changes in variants\XIAO_m0\variant.h:
#define PIN_LED2 (12u)
#define PIN_LED3 (11u)
#if defined(TXRXLED_ENABLE)
#define PIN_LED_RXL PIN_LED2
#define PIN_LED_TXL PIN_LED3
#endif
Also, assigning the pin-numbers to PIN_LED2/3 (instead of PIN_LED_RXL/TXL) allows the user to reference the individual LED-pins, while still being able to enable/disable the LEDs with the compiler flag.

Please also correct the copy-paste typo in boards.txt for the Wio Lite MG126
from
# Seeed XIAO M0 (SAMD21)
to
# Wio Lite MG126 (SAMD21)

@MatthewJeffson MatthewJeffson added UAY Unassigned yet ArduinoCore-samd Label for ArduinoCore-samd labels Oct 9, 2024
@Lesords Lesords self-assigned this Oct 14, 2024
@Lesords
Copy link

Lesords commented Oct 16, 2024

Hello,

I'm very sorry to have kept you waiting so long.

I will solve the problem you mentioned later or we also welcome you to submit PR.

@Lesords Lesords moved this from Todo to In Progress in Issues and PR Assemble Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArduinoCore-samd Label for ArduinoCore-samd UAY Unassigned yet
Projects
Status: In Progress
Development

No branches or pull requests

3 participants