bug(tools): Updating tools hangs and results 500 error

[psyray]

Is there an existing issue for this?

• I have searched the existing issues

Current Behavior

From @PekkaJalonen

When updating some tools in arsenal, example ctfr will caus web to hang with "Downloading laterst version..." and looking at the container logs, it shows:

django.server | "GET /api/github/tool/get_latest_releases/?tool_id=12 HTTP/1.0" 200 38
run_command | INFO | cd /usr/src/github/ctfr && git pull && cd -
run_command | WARNING | None
django.server | "GET /api/tool/update/?tool_id=12 HTTP/1.0" 500 133332

Expected Behavior

Update should respond if the update was successfull or not.

Steps To Reproduce

1. In tool arsenal, select ctfr and click Check Update
2. Click Force download
3. Web page hangs in "Downloading laterst version..."

Environment

- reNgine: 2.0.2 (fresh install)
- OS: Ubuntu 22.04
- Python: 3.10.12
- Docker Engine: 24.0.6
- Docker Compose: 2.21.0
- Browser: Microsoft Edge 120.0.2210.61

Anything else?

No response

[psyray]

I can reproduce

I will have a look

I've tested again it happens when you click on Force download.
In this case there is no way to update automatically.

Seems there is a problem of subprocess params not well exploded

[psyray]

@AnonymousWP For this one this need more modifications because of poetry.
Actual code will fail updating the software as it relay on pip

I think we should remove the Update functionality for the moment.
Are you agree ?

[AnonymousWP]

@AnonymousWP For this one this need more modifications because of poetry. Actual code will fail updating the software as it relay on pip

I think we should remove the Update functionality for the moment. Are you agree ?

Hmm, and bring it back in 2.2.0?

[psyray]

@AnonymousWP For this one this need more modifications because of poetry. Actual code will fail updating the software as it relay on pip
I think we should remove the Update functionality for the moment. Are you agree ?

Hmm, and bring it back in 2.2.0?

Yes

[AnonymousWP]

It's a pretty severe bug though, so not sure about this decision.

[psyray]

It's a pretty severe bug though, so not sure about this decision.

It will not exists anymore when update button and API endpoint will be deactivated.
At the time it will broke all the system if we leave it in the 2.1.0 because of the poetry use
So best is to deactivate and control ourself the tools update.
By the past I've seen reNgine stops to work after a tool upgrade because of a regression or a fresh bug.
I think it's better for stability

[AnonymousWP]

Good point.