Skip to content

Commit 7c2aed7

Browse files
shs96cshs96c
committed
Correct ignored tests for geckodriver 0.16
1 parent 9d3ea5a commit 7c2aed7

15 files changed

+4
-74
lines changed

‎java/client/test/org/openqa/selenium/AlertsTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -333,7 +333,6 @@ public void testPromptShouldHaveNullValueIfDismissed() {
333333
}
334334

335335
@Test
336-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/607")
337336
public void testHandlesTwoAlertsFromOneInteraction() {
338337
driver.get(appServer.create(new Page()
339338
.withScripts(

‎java/client/test/org/openqa/selenium/ClickScrollingTest.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,7 @@
3737
import org.openqa.selenium.interactions.MoveTargetOutOfBoundsException;
3838
import org.openqa.selenium.testing.Ignore;
3939
import org.openqa.selenium.testing.JUnit4TestBase;
40+
import org.openqa.selenium.testing.NotYetImplemented;
4041
import org.openqa.selenium.testing.SwitchToTopAfterTest;
4142

4243
@Ignore(value = HTMLUNIT, reason = "Scrolling requires rendering")
@@ -86,6 +87,7 @@ public void testShouldBeAbleToClickOnAnElementHiddenByOverflow() {
8687

8788
@Test
8889
@Ignore(value = CHROME, reason = "failed")
90+
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/662")
8991
public void testShouldBeAbleToClickOnAnElementHiddenByDoubleOverflow() {
9092
driver.get(appServer.whereIs("scrolling_tests/page_with_double_overflow_auto.html"));
9193

@@ -192,6 +194,7 @@ public void testShouldBeAbleToClickElementThatIsOutOfViewInAFrameThatIsOutOfView
192194
@SwitchToTopAfterTest
193195
@Test
194196
@Ignore(SAFARI)
197+
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/651")
195198
public void testShouldBeAbleToClickElementThatIsOutOfViewInANestedFrame() {
196199
driver.get(appServer.whereIs("scrolling_tests/page_with_nested_scrolling_frames.html"));
197200
driver.switchTo().frame("scrolling_frame");
@@ -204,6 +207,7 @@ public void testShouldBeAbleToClickElementThatIsOutOfViewInANestedFrame() {
204207
@SwitchToTopAfterTest
205208
@Test
206209
@Ignore(SAFARI)
210+
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/651")
207211
public void testShouldBeAbleToClickElementThatIsOutOfViewInANestedFrameThatIsOutOfView() {
208212
driver.get(appServer.whereIs("scrolling_tests/page_with_nested_scrolling_frames_out_of_view.html"));
209213
driver.switchTo().frame("scrolling_frame");

‎java/client/test/org/openqa/selenium/ClickTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,6 @@ public void testJsLocatedElementsCanUpdateFramesIfFoundSomehowElse() {
123123
}
124124

125125
@Test
126-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
127126
public void testCanClickOnAnElementWithTopSetToANegativeNumber() {
128127
String page = appServer.whereIs("styledPage.html");
129128
driver.get(page);

‎java/client/test/org/openqa/selenium/ContentEditableTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,6 @@ public void testShouldBeAbleToTypeIntoContentEditableElementWithExistingValue()
111111
@Test
112112
@Ignore(IE)
113113
@Ignore(value = SAFARI, reason = "cannot type on contentEditable with synthetic events, issue 3127")
114-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
115114
public void testShouldBeAbleToTypeIntoTinyMCE() {
116115
driver.get(appServer.whereIs("tinymce.html"));
117116
driver.switchTo().frame("mce_0_ifr");

‎java/client/test/org/openqa/selenium/ElementAttributeTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,6 @@ public void testGetAttributeDoesNotReturnAnObjectForSvgProperties() {
318318
}
319319

320320
@Test
321-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
322321
public void testCanRetrieveTheCurrentValueOfATextFormField_textInput() {
323322
driver.get(pages.formPage);
324323
WebElement element = driver.findElement(By.id("working"));
@@ -328,7 +327,6 @@ public void testCanRetrieveTheCurrentValueOfATextFormField_textInput() {
328327
}
329328

330329
@Test
331-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
332330
public void testCanRetrieveTheCurrentValueOfATextFormField_emailInput() {
333331
driver.get(pages.formPage);
334332
WebElement element = driver.findElement(By.id("email"));
@@ -338,7 +336,6 @@ public void testCanRetrieveTheCurrentValueOfATextFormField_emailInput() {
338336
}
339337

340338
@Test
341-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
342339
public void testCanRetrieveTheCurrentValueOfATextFormField_textArea() {
343340
driver.get(pages.formPage);
344341
WebElement element = driver.findElement(By.id("emptyTextArea"));

‎java/client/test/org/openqa/selenium/ExecutingAsyncJavascriptTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -241,7 +241,6 @@ public void shouldCatchErrorsWithMessageAndStacktraceWhenExecutingInitialScript(
241241
}
242242

243243
@Test
244-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
245244
public void shouldBeAbleToExecuteAsynchronousScripts() {
246245
driver.get(pages.ajaxyPage);
247246

‎java/client/test/org/openqa/selenium/FormHandlingTest.java

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,6 @@ public void testShouldNotBeAbleToSubmitAFormThatDoesNotExist() {
103103
}
104104

105105
@Test
106-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
107106
public void testShouldBeAbleToEnterTextIntoATextAreaBySettingItsValue() {
108107
driver.get(pages.javascriptPage);
109108
WebElement textarea = driver.findElement(By.id("keyUpArea"));
@@ -113,7 +112,6 @@ public void testShouldBeAbleToEnterTextIntoATextAreaBySettingItsValue() {
113112
}
114113

115114
@Test
116-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
117115
public void testSendKeysKeepsCapitalization() {
118116
driver.get(pages.javascriptPage);
119117
WebElement textarea = driver.findElement(By
@@ -135,7 +133,6 @@ public void testShouldSubmitAFormUsingTheNewlineLiteral() {
135133
}
136134

137135
@Test
138-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
139136
public void testShouldSubmitAFormUsingTheEnterKey() {
140137
driver.get(pages.formPage);
141138
WebElement nestedForm = driver.findElement(By.id("nested_form"));
@@ -146,7 +143,6 @@ public void testShouldSubmitAFormUsingTheEnterKey() {
146143
}
147144

148145
@Test
149-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
150146
public void testShouldEnterDataIntoFormFields() {
151147
driver.get(pages.xhtmlTestPage);
152148
WebElement element = driver.findElement(By.xpath("//form[@name='someForm']/input[@id='username']"));
@@ -225,7 +221,6 @@ public void testShouldBeAbleToUploadTheSameFileTwice() throws IOException {
225221
}
226222

227223
@Test
228-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
229224
public void testSendingKeyboardEventsShouldAppendTextInInputs() {
230225
driver.get(pages.formPage);
231226
WebElement element = driver.findElement(By.id("working"));
@@ -239,7 +234,6 @@ public void testSendingKeyboardEventsShouldAppendTextInInputs() {
239234
}
240235

241236
@Test
242-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
243237
public void testSendingKeyboardEventsShouldAppendTextInInputsWithExistingValue() {
244238
driver.get(pages.formPage);
245239
WebElement element = driver.findElement(By.id("inputWithText"));
@@ -250,7 +244,6 @@ public void testSendingKeyboardEventsShouldAppendTextInInputsWithExistingValue()
250244
}
251245

252246
@Test
253-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
254247
public void testSendingKeyboardEventsShouldAppendTextInTextAreas() {
255248
driver.get(pages.formPage);
256249
WebElement element = driver.findElement(By.id("withText"));
@@ -286,21 +279,18 @@ public void handleFormWithJavascriptAction() {
286279

287280
@Test
288281
@Ignore(SAFARI)
289-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
290282
public void testCanClickOnASubmitButton() {
291283
checkSubmitButton("internal_explicit_submit");
292284
}
293285

294286
@Test
295287
@Ignore(SAFARI)
296-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
297288
public void testCanClickOnASubmitButtonNestedSpan() {
298289
checkSubmitButton("internal_span_submit");
299290
}
300291

301292
@Test
302293
@Ignore(SAFARI)
303-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
304294
public void testCanClickOnAnImplicitSubmitButton() {
305295
assumeFalse(isIe6(driver) || isIe7(driver) );
306296
checkSubmitButton("internal_implicit_submit");
@@ -309,15 +299,13 @@ public void testCanClickOnAnImplicitSubmitButton() {
309299
@Test
310300
@Ignore(IE)
311301
@Ignore(SAFARI)
312-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
313302
public void testCanClickOnAnExternalSubmitButton() {
314303
checkSubmitButton("external_explicit_submit");
315304
}
316305

317306
@Test
318307
@Ignore(IE)
319308
@Ignore(SAFARI)
320-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
321309
public void testCanClickOnAnExternalImplicitSubmitButton() {
322310
checkSubmitButton("external_implicit_submit");
323311
}

‎java/client/test/org/openqa/selenium/FrameSwitchingTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -510,7 +510,6 @@ public void testJavaScriptShouldExecuteInTheContextOfTheCurrentFrame() {
510510
}
511511

512512
@Test
513-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
514513
public void testShouldNotSwitchMagicallyToTheTopWindow() {
515514
String baseUrl = appServer.whereIs("frame_switching_tests/");
516515
driver.get(baseUrl + "bug4876.html");

‎java/client/test/org/openqa/selenium/I18nTest.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,6 @@ public void testCn() {
6565
}
6666

6767
@Test
68-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
6968
public void testEnteringHebrewTextFromLeftToRight() {
7069
driver.get(pages.chinesePage);
7170
WebElement input = driver.findElement(By.name("i18n"));
@@ -76,7 +75,6 @@ public void testEnteringHebrewTextFromLeftToRight() {
7675
}
7776

7877
@Test
79-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
8078
public void testEnteringHebrewTextFromRightToLeft() {
8179
driver.get(pages.chinesePage);
8280
WebElement input = driver.findElement(By.name("i18n"));

‎java/client/test/org/openqa/selenium/JavascriptEnabledDriverTest.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -41,9 +41,6 @@
4141
import org.openqa.selenium.testing.NeedsFreshDriver;
4242
import org.openqa.selenium.testing.NotYetImplemented;
4343

44-
/**
45-
* Test case for browsers that support using Javascript
46-
*/
4744
public class JavascriptEnabledDriverTest extends JUnit4TestBase {
4845

4946
@Test
@@ -93,7 +90,6 @@ public void testShouldBeAbleToFindElementAfterJavascriptCausesANewPageToLoad() {
9390
}
9491

9592
@Test
96-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
9793
public void testShouldFireOnChangeEventWhenSettingAnElementsValue() {
9894
driver.get(pages.javascriptPage);
9995
driver.findElement(By.id("change")).sendKeys("foo");
@@ -162,7 +158,6 @@ public void testIfNoElementHasFocusTheActiveElementIsTheBody() {
162158

163159
@Test
164160
@Ignore(value = SAFARI, reason = "issue 4061")
165-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
166161
public void testChangeEventIsFiredAppropriatelyWhenFocusIsLost() {
167162
driver.get(pages.javascriptPage);
168163

‎java/client/test/org/openqa/selenium/TextHandlingTest.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -190,7 +190,6 @@ public void testShouldRetainTheFormatingOfTextWithinAPreElementThatIsWithinARegu
190190

191191
@Test
192192
@Ignore(value = IE, reason = "IE: inserts \r\n instead of \n")
193-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
194193
public void testShouldBeAbleToSetMoreThanOneLineOfTextInATextArea() {
195194
driver.get(pages.formPage);
196195
WebElement textarea = driver.findElement(By.id("withText"));
@@ -207,7 +206,6 @@ public void testShouldBeAbleToSetMoreThanOneLineOfTextInATextArea() {
207206
}
208207

209208
@Test
210-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
211209
public void testShouldBeAbleToEnterDatesAfterFillingInOtherValuesFirst() {
212210
driver.get(pages.formPage);
213211
WebElement input = driver.findElement(By.id("working"));
@@ -351,7 +349,6 @@ public void testTextOfATextAreaShouldBeEqualToItsDefaultText() {
351349

352350
@Test
353351
@Ignore(IE)
354-
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/594")
355352
public void testTextOfATextAreaShouldBeEqualToItsDefaultTextEvenAfterTyping() {
356353
driver.get(pages.formPage);
357354
WebElement area = driver.findElement(By.id("withText"));

0 commit comments

Comments
 (0)