fix(bucket): Return empty list correctly in Get-LocalBucket
#4885
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return a zero-length list instead of
$null
inGet-LocalBucket
.Adjust the output message for
scoop alias list
when there is no alias found.Adjust the output message for
scoop cache show
when there is no cache found.Motivation and Context
I ran into an error when I removed all buckets and was trying to add them back using URLs of mirrors, which means running
scoop bucket list
when there is nothing in$SCOOP\buckets
:The
Get-LocalBucket
returns$null
in this case, soFind-BucketDirectory
gets the default valuemain
for$Name
:Scoop/lib/buckets.ps1
Lines 126 to 128 in e6d0371
Scoop/lib/buckets.ps1
Lines 13 to 14 in e6d0371
To fix this, we should use a zero-length list instead and give a tip of adding the default
main
bucket.No additional description.
scoop cache show
shows the following message when there is no cache found:I think it's better to change it to something like this:
How Has This Been Tested?
Just run as usual:
Checklist: