Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(scoop-info): Revamp details and show more information #4747

Merged
merged 11 commits into from
Feb 25, 2022

Conversation

rashil2000
Copy link
Member

Description

MASSIVE new changes in scoop-info!!!

Show a lot more information, and hide sensitive details behind the 'verbose' flag.

Check the commit messages for more details.

Motivation and Context

Closes #4448

How Has This Been Tested?

Checklist:

  • I have read the Contributing Guide.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.

libexec/scoop-info.ps1 Outdated Show resolved Hide resolved
libexec/scoop-info.ps1 Show resolved Hide resolved
libexec/scoop-info.ps1 Outdated Show resolved Hide resolved
libexec/scoop-info.ps1 Show resolved Hide resolved
libexec/scoop-info.ps1 Outdated Show resolved Hide resolved
@niheaven
Copy link
Member

  1. For the argument, what do you think is better? --all vs. --verbose. Since verbose is used for displaying intermediate process output, a detailed one, while all means full one. I think here the argument triggers full output (though it provides more details).
  2. The default output adds Updated at and Updated by entries, which spends more times since the git log searching, so should we move them to full one?

@rashil2000
Copy link
Member Author

The intention for verbose flag was to actually hide local filepaths (which caused a lot of clutter in the info and were also unsafe in case you want to share it online).

  • --all would mean that show info for all apps matching the query. This is how apt handles it. I think --verbose is more clear as to what is being done. (actually, we could also use --full).
  • The Updated at field is very useful (as mentioned in the linked issue), and since it is not showing any sensitive info, I decided to show it without the flag.

@niheaven
Copy link
Member

Okay, I prefer using --full, verbose is strange for this simple/full switch.

I'm working on using SQLite to cache information of manifests, apps and shims, maybe that will speed up scoop-info and scoop-search (also scoop-list, scoop-shim).

@rashil2000
Copy link
Member Author

--full will get abbreviated to -f, which can confuse users with --force (usually)? 😅

@niheaven
Copy link
Member

Hmm, make sense. Use verbose now, change if needed.

libexec/scoop-info.ps1 Outdated Show resolved Hide resolved
Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
@rashil2000 rashil2000 merged commit aa61f19 into develop Feb 25, 2022
@rashil2000 rashil2000 deleted the revamp-info branch February 25, 2022 07:36
se35710 pushed a commit to se35710/scoop that referenced this pull request Mar 8, 2022
…aller#4747)

* feat(scoop-info): Introduce `verbose` flag

* feat(scoop-info): Allow passing local manifest paths

* feat(scoop-info): Show bucket and shortcuts

* feat(scoop-info): Show dependencies and suggestions

* feat(scoop-info): Show 'Updated at' and 'Updated by'

* changelog

* optimize git call

* restore clicky-ness of homepage

* simplify joining

* use getopt

* Update libexec/scoop-info.ps1

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>

Co-authored-by: Hsiao-nan Cheung <niheaven@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants