Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NW.js doesn't close properly. #8221

Open
BluePinStudio opened this issue Sep 14, 2024 · 2 comments
Open

NW.js doesn't close properly. #8221

BluePinStudio opened this issue Sep 14, 2024 · 2 comments
Assignees

Comments

@BluePinStudio
Copy link

BluePinStudio commented Sep 14, 2024

Problem description

Whenever a user closes the nw.js built game, there's a high percentage chance (over 50% from my experience) that the nw.js window closes but nw.js remains an open task in the background. It can be seen in task manager,

This prevents the user from opening the game again when they try to launch the nw.js build. This also shows that the user is "playing the game" on Steam.

Attach a .c3p

No .c3p required. I tested it, and it occurs with construct example projects built with latest version of nw.js

Steps to reproduce

  1. Open any example project
  2. Go to export and select nw.js
  3. Select latest version of nw.js and build
  4. Wait for build to complete
  5. Open the resulting nw.js build
  6. Close the game
  7. Inspect your task manager, and you'll see its still open even though the window is gone.
  8. If it closed successfully, repeat step 5-7 again. Its not 100% reproducible, more like 50%.

Observed result

Nw.js remains technically open via a background task that isn't terminated

Expected result

It should close the window and the task 100% of the time.

More details

This is a regression, the issue has been documented and fixed in the past.

@AshleyScirra AshleyScirra self-assigned this Sep 16, 2024
@AshleyScirra
Copy link
Member

I will try to take a look at this, but it may be that it ends up being a problem with NW.js itself and outside of our control, so you may want to report it directly to NW.js instead.

If you are publishing for Windows, where possible I would advise to use the Windows WebView2 export option instead - it's better supported and is our own wrapper so it's much easier for us to fix any issues that come up with it.

@JeFawk
Copy link

JeFawk commented Oct 2, 2024

I've encountered this issue for at least 7 years, with NWjs still in the background after the game closes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants