Skip to content

Commit 79b842b

Browse files
authored
Merge pull request #146 from ScienceCommons/remove-esc-key-embed-viewer
Remove ESC key functionality, which closes embedded viewer
2 parents 4cca5bf + 3047e23 commit 79b842b

File tree

2 files changed

+1
-15
lines changed

2 files changed

+1
-15
lines changed

dist/js/bundle.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/components/EmbeddedViewer.jsx

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -85,20 +85,6 @@ export default withRouter(function EmbeddedViewer({ history }) {
8585
closeViewer()
8686
}, [history.location.pathname])
8787

88-
// Close viewer on ESC
89-
useEffect(() => {
90-
if (viewer_visible) {
91-
function close_on_escape(event) {
92-
if (event.key === 'Escape') {
93-
closeViewer()
94-
}
95-
}
96-
97-
window.addEventListener('keyup', close_on_escape);
98-
return () => window.removeEventListener('keyup', close_on_escape);
99-
}
100-
}, [viewer_visible]);
101-
10288
return (
10389
<div className={classes.viewer} style={style}>
10490
<iframe style={{height: '100%', width: '100%', border: 'solid 1px', flex: 1}} src={view_url.url}></iframe>

0 commit comments

Comments
 (0)