Skip to content

Conversation

@bouweandela
Copy link
Member

First attempt at supporting dask arrays.

See #47 and ESMValGroup/ESMValCore#35.

@bouweandela
Copy link
Member Author

@bjlittle If you look at the profile_stratify.ipynb notebook, you'll see that the problem originally was that interpolating to a single target level was very much slower on a dask array than on a numpy array. However, when I run the same code now the problem seems to have disappeared, so I think the approach here is viable.

@bjlittle bjlittle self-assigned this Oct 19, 2022
@bjlittle bjlittle marked this pull request as ready for review October 19, 2022 13:42
@bjlittle
Copy link
Member

@bouweandela Awesome, thanks! 🥳

I'm simply going to merge this PR "as-is", even though the CI is failing.

The infra-structure of python-stratify needs quite a bit of love as it's sadly gone stale, so I'm going to take care of that as a separate concern.

Any changes required to tweak your PR contribution can be addressed as an immediate follow-up before making this lazy feature available in a forth-coming release - I'm happy to do that on your behalf 👍

The tests are passing locally, and that's good enough for me given the current state of affairs to unblock this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants