Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CITATION.cff with contributor ORCIDs #136

Merged
merged 3 commits into from
May 24, 2023

Conversation

bjlittle
Copy link
Member

@bjlittle bjlittle commented May 12, 2023

🚀 Pull Request

Description

This PR updates the CITATION.cff file with most of our contributor ORCID details, as per issue #135.

I'm rolling with the 80/20 rule i.e., we can bank the majority of the ORCIDs now.

Note that, I've ordered the entries alphabetically by surname, which seems reasonable.

I'll leave issue #135 open and pinned for now. Perhaps our remaining contributors may get back to us at some point, or raise a pull-request themselves. We'll see ...

@codecov-commenter
Copy link

codecov-commenter commented May 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ef60bd4) 97.36% compared to head (9c57485) 97.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #136   +/-   ##
=======================================
  Coverage   97.36%   97.36%           
=======================================
  Files           7        7           
  Lines         644      644           
=======================================
  Hits          627      627           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bjlittle! I will maybe defer to @pelson and @lbdreyer on the order of the names, since as I understand it they were the ones to initially conceptualize and package up nc-time-axis. This otherwise looks good to me.

@pelson
Copy link
Member

pelson commented May 15, 2023

I will maybe defer to @pelson and @lbdreyer on the order of the names, since as I understand it they were the ones to initially conceptualize and package up nc-time-axis

Sure, but it is a team effort to keep it going, so from my perspective, I'm happy with whatever order is chosen, including if Laura wants to be lead-author.

@bjlittle
Copy link
Member Author

bjlittle commented May 15, 2023

Okay, I totally hear what @pelson saying, but I love the intent of @spencerkclark's point, so let's recognise that and seed the list with @lbdreyer and @pelson who are the creators of nc-time-axis 💯 ❤️

Copy link
Member

@spencerkclark spencerkclark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjlittle indeed I like that idea a lot! Thanks @pelson for weighing in. Assuming @lbdreyer is good with it too, I think this is ready to go.

@lbdreyer
Copy link
Member

I'm not concerned by the order of names, so happy to go with alphabetical or as it currently is

@bjlittle
Copy link
Member Author

@spencerkclark I think this PR is now good to bank?

@spencerkclark
Copy link
Member

Yes, thanks @bjlittle and @lbdreyer! I’ll go ahead and merge.

@spencerkclark spencerkclark merged commit 1ebeb71 into SciTools:main May 24, 2023
@bjlittle bjlittle deleted the update-citation-cff branch May 24, 2023 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants