Skip to content

removed cell measure mask check and error #5181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Feb 28, 2023
Merged

removed cell measure mask check and error #5181

merged 7 commits into from
Feb 28, 2023

Conversation

@ESadek-MO
Copy link
Contributor

@ESadek-MO ESadek-MO commented Feb 27, 2023

🚀 Pull Request

Closes #5147.

Description

Removed check and error raise for saving cubes with masked cell measures.

ESadek-MO
ESadek-MO commented Feb 27, 2023
View reviewed changes
@pp-mo
Copy link
Member

pp-mo commented Feb 27, 2023

Hi @ESadek-MO
Note that, if you have git pre-commit enabled on your local repo clone, then style errors like 2498f9b should not occur, because it will be fixed whenever you make a commit.

For this, you need to run from an env containing 'pre-commit', and you need (just once) to run "pre-commit install" within you local repo clone (i.e. the checkout on disk). Then it runs black via the .pre-commit-config.yaml

There is some written explanation here : https://scitools-iris.readthedocs.io/en/stable/developers_guide/contributing_code_formatting.html?highlight=pre-commit

Sorry if you already know all this !!

pp-mo
pp-mo reviewed Feb 27, 2023
View reviewed changes
@ESadek-MO ESadek-MO marked this pull request as ready for review February 28, 2023 10:00
pp-mo
pp-mo approved these changes Feb 28, 2023
View reviewed changes
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think this is OK now, with nothing in place of the old test.

@pp-mo pp-mo merged commit 897a7cb into SciTools:main Feb 28, 2023
@pp-mo
Copy link
Member

pp-mo commented Feb 28, 2023

Nice job @ESadek-MO . Sorry for all my fretting over the broken test !

@ESadek-MO ESadek-MO deleted the masked-cell-measures branch February 28, 2023 10:08
tkknight added a commit to tkknight/iris that referenced this pull request Apr 22, 2023
@tkknight
Merge remote-tracking branch 'upstream/main' into dark_theme
c1e6e47 
* upstream/main: (23 commits)
  Lockfiles and pydata-sphinx-theme fix (SciTools#5188)
  Allow smarter weights (cubes, coordinates, cell measures, or ancillary variables) for aggregation (SciTools#5084)
  removed cell measure mask check and error (SciTools#5181)
  Updated environment lockfiles (SciTools#5177)
  Lazy weighted RMS calculation (SciTools#5017)
  Add coverage badge to README.md (SciTools#5176)
  Add coverage testing (SciTools#4765)
  Whats new updates for v3.4.1 .
  NetCDF thread safety take two (SciTools#5095)
  Updated environment lockfiles (SciTools#5163)
  Plugin support (SciTools#5144)
  Expand scope of common contributor links (SciTools#5159)
  Replace apparently retired UDUNITS documentation link. (SciTools#5153)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5150)
  Fixing typo's in Gitwash. (SciTools#5145)
  add readme #showyourstripes (SciTools#5141)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5143)
  Iris ❤ Xarray docs page. (SciTools#5025)
  [pre-commit.ci] pre-commit autoupdate (SciTools#5136)
  Updated citation (SciTools#5116)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pp-mo pp-mo pp-mo approved these changes

Assignees

No one assigned

Labels

None yet

Projects

ESMValTool
Status: ✅ Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

saving cubes with masked cell measures

2 participants

@ESadek-MO @pp-mo