Cube printout #3998
Closed
Cube printout #3998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
At this point, nearly there. |
|
Ok, finally complete ! Please review. |
Merged
|
Following offline discussion with @stephenworsley , we think we are now fairly confident in the "old/new equivalence testing" here, and the scope of the new tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
Adds cube printout code, based on
iris._representation.CubeSummary.This supercedes #3982
N.B. we already merged the
iris._representation.SubeCummaryPR.As it happens that is all private, and nothing else yet uses it, so we can still evolve that if needed.
Eventually we will replace the existing
Cube.summarycode with this (but not just yet)Consult Iris pull request check list