Skip to content

Conversation

@trexfeathers
Copy link
Contributor

Closes #188

@trexfeathers trexfeathers marked this pull request as draft April 19, 2024 17:25
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than tiny query -- LGTM

Comment on lines 795 to 798
if not (
np.isclose(section["longitudeOfLastGridPoint"], final_x_point)
and np.isclose(section["latitudeOfLastGridPoint"], final_y_point)
):
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experiments so far have produced many cases where this block is true, which makes me worried I need an extra factor in here like scaling or units or something. That's why I changed the PR back to draft.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still unsure about this one, but if @pp-mo has no objections I guess I'll take it out of draft.

Copy link
Member

@pp-mo pp-mo Sep 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess your experiments might indicate that more tolerance is required.
Since it's only a double-check, we can afford to be tolerant, don't want to be crying wolf.
Maybe something like atol=0.5 rtol=0.001 ?
So 10. +/- 0.5, 10,000. +/- 10.

@trexfeathers trexfeathers marked this pull request as ready for review September 10, 2024 15:04
@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2024

Codecov Report

❌ Patch coverage is 94.64286% with 3 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@b0f4584). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/iris_grib/__init__.py 91.66% 0 Missing and 2 partials ⚠️
src/iris_grib/message.py 88.88% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #446   +/-   ##
=======================================
  Coverage        ?   89.64%           
=======================================
  Files           ?        8           
  Lines           ?     2481           
  Branches        ?      422           
=======================================
  Hits            ?     2224           
  Misses          ?      159           
  Partials        ?       98           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@scitools-ci scitools-ci bot removed this from 🚴 Peloton Sep 24, 2025
@ESadek-MO ESadek-MO assigned trexfeathers and unassigned pp-mo Oct 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Incomplete validity checking in GDT 3.10

3 participants