-
Notifications
You must be signed in to change notification settings - Fork 44
Handle missing keys for GDT10 Mercator #446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than tiny query -- LGTM
| if not ( | ||
| np.isclose(section["longitudeOfLastGridPoint"], final_x_point) | ||
| and np.isclose(section["latitudeOfLastGridPoint"], final_y_point) | ||
| ): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Experiments so far have produced many cases where this block is true, which makes me worried I need an extra factor in here like scaling or units or something. That's why I changed the PR back to draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still unsure about this one, but if @pp-mo has no objections I guess I'll take it out of draft.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess your experiments might indicate that more tolerance is required.
Since it's only a double-check, we can afford to be tolerant, don't want to be crying wolf.
Maybe something like atol=0.5 rtol=0.001 ?
So 10. +/- 0.5, 10,000. +/- 10.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #446 +/- ##
=======================================
Coverage ? 89.64%
=======================================
Files ? 8
Lines ? 2481
Branches ? 422
=======================================
Hits ? 2224
Misses ? 159
Partials ? 98 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #188