From eb0f02577290d930930349870b161e85553e967a Mon Sep 17 00:00:00 2001
From: barfeous <nzksf2wa@duck.com>
Date: Mon, 12 Feb 2024 13:28:54 -0600
Subject: [PATCH 1/3] avoid modifying collection

---
 .../Training/Saving/SavedModel/AugmentedGraphView.cs          | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs b/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs
index a91933357..c6b26ff49 100644
--- a/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs
+++ b/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs
@@ -88,7 +88,7 @@ private ConcreteFunction maybe_uncache_variable_captures(ConcreteFunction concre
 
     public override (IList<Trackable>, IDictionary<Trackable, IEnumerable<TrackableReference>>) breadth_first_traversal()
     {
-        Trackable get_merged_trackable(Trackable x)
+        void merged_trackable(Trackable x)
         {
             // TODO: complete it with new definitions `Asset` and `TrackableConstant`.
             return x;
@@ -100,7 +100,7 @@ Trackable get_merged_trackable(Trackable x)
             // skip the deletion of cache (maybe do it later).
             foreach(var pair in _children_cache[obj])
             {
-                _children_cache[obj][pair.Key] = get_merged_trackable(pair.Value);
+                merged_trackable(pair.Value);
             }
         }
 

From 3448b6434680270026a0f938e913ff1f08f1df9b Mon Sep 17 00:00:00 2001
From: barfeous <nzksf2wa@duck.com>
Date: Wed, 14 Feb 2024 20:25:15 -0600
Subject: [PATCH 2/3] Remove parameter return from newly void local method

---
 .../Training/Saving/SavedModel/AugmentedGraphView.cs            | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs b/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs
index c6b26ff49..3b4bbdc63 100644
--- a/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs
+++ b/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs
@@ -91,8 +91,8 @@ public override (IList<Trackable>, IDictionary<Trackable, IEnumerable<TrackableR
         void merged_trackable(Trackable x)
         {
             // TODO: complete it with new definitions `Asset` and `TrackableConstant`.
-            return x;
         }
+
         var trackable_objects = base.breadth_first_traversal();
 
         foreach(var obj in _children_cache.Keys)

From 4a31621a5632c7d6b2ebca1d36561458b91367c5 Mon Sep 17 00:00:00 2001
From: barfeous <nzksf2wa@duck.com>
Date: Sun, 28 Apr 2024 13:04:07 -0500
Subject: [PATCH 3/3] Use TryGetValue instead of ContainsKey + []

---
 .../Training/Saving/SavedModel/AugmentedGraphView.cs      | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

diff --git a/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs b/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs
index 3b4bbdc63..9d0b3f001 100644
--- a/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs
+++ b/src/TensorFlowNET.Core/Training/Saving/SavedModel/AugmentedGraphView.cs
@@ -109,15 +109,11 @@ void merged_trackable(Trackable x)
 
     public List<(string, Trackable)> list_dependencies(Trackable obj)
     {
-        IDictionary<string, Trackable> children;
-        if (!_children_cache.ContainsKey(obj))
+        if (!_children_cache.TryGetValue(obj, out var children))
         {
             children= new Dictionary<string, Trackable>();
         }
-        else
-        {
-            children= _children_cache[obj];
-        }
+
         List<(string, Trackable)> res = new();
         foreach(var pair in obj.deserialization_dependencies(children))
         {