Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Defer to warn about spreadsheet and mechanize gems #456

Closed
mrkn opened this issue Apr 7, 2018 · 3 comments
Closed

Defer to warn about spreadsheet and mechanize gems #456

mrkn opened this issue Apr 7, 2018 · 3 comments

Comments

@mrkn
Copy link
Contributor

mrkn commented Apr 7, 2018

screenshot 2018-04-08 00 18 43

Currently, daru always shows two warnings about spreadsheet and mechanize gems even if users don't need the functions of them.

I think these warnings should be deferred until users try to use them.
@athityakumar
Copy link
Member

This definitely is fixed in daru-io, but the existing IO modules in daru (before daru-io) are yet to be removed. I had opened PR #430 for the same, and it's yet to be merged.

@IsmailM
Copy link

IsmailM commented Apr 26, 2018

There's a previous issue on this from around 8 months ago - #404...

@zverok
Copy link
Collaborator

zverok commented Jul 1, 2018

Fixed in master and will be released in a day or two.

@zverok zverok closed this as completed Jul 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mrkn @zverok @IsmailM @athityakumar