This repository was archived by the owner on May 15, 2025. It is now read-only.
Force ADTypes v1 #143
Merged
Force ADTypes v1 #143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
@ChrisRackauckas can you approve the workflows? |
|
@avik-pal can you handle the unexpected passes? https://github.com/SciML/SimpleNonlinearSolve.jl/actions/runs/9128228158/job/25100141056?pr=143#step:6:670 |
|
This is that strange issue where Mac behaves differently from other OS. Setting them to pass in Mac will cause Windows and Linux to fail |
|
At least setup an if Mac then not broken so tests pass |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Force the use of ADTypes v1 instead of allowing v0.2 as well. I don't think this requires internal changes for this package, but it will break downstream.