Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why are we warning about events regardless of if the model has events? #91

Closed
anandijain opened this issue Oct 20, 2022 · 3 comments · Fixed by #100
Closed

why are we warning about events regardless of if the model has events? #91

anandijain opened this issue Oct 20, 2022 · 3 comments · Fixed by #100

Comments

@anandijain
Copy link
Contributor

https://github.com/SciML/SBMLToolkit.jl/blob/main/src/events.jl

not a big deal though
@paulflang
Copy link
Member

good point. should go in the next pr.

@xlxs4
Copy link
Contributor

xlxs4 commented Dec 10, 2022

So just a

!isempty(evs) && @warn "SBMLToolkit currently fires events regardless of uppass or downpass trigger."

?

@paulflang
Copy link
Member

@xlxs4 yes. do you want to create a pr. otherwise i'll do.

@xlxs4 xlxs4 mentioned this issue Dec 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only warn for events if model has events xlxs4/SBMLToolkit.jl
3 participants
@anandijain @paulflang @xlxs4