Merged
Conversation
- Extend `SciMLBase` compat to `"1.73, 2, 3.1"` (keep v2 support).
- Bump version to 3.18.0.
- Add a `SciMLBase.derivative_discontinuity!(::ODEInterfaceIntegrator, ::Bool)`
overload alongside the existing `DiffEqBase.u_modified!` method, guarded
by `@static if isdefined(SciMLBase, :derivative_discontinuity!)`.
SciMLBase v3 renamed `u_modified!` → `derivative_discontinuity!` with an
`@deprecate` shim on the old name. The existing `u_modified!` overload for
`ODEInterfaceIntegrator` still dispatches for legacy callers, but any
caller that has migrated to the new name would hit the generic
`error("method has not been implemented for the integrator")` fallback —
the new method closes that gap. The `isdefined` guard keeps the file
compiling on SciMLBase v2.
Note: local tests cannot be run — `Pkg.resolve()` fails for any env
containing SciMLBase 3.1 because OrdinaryDiffEq in the registry still
pins `RecursiveArrayTools ≤ 3.54`. CI will reproduce the same resolution
error until upstream bumps.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Chris Rackauckas <accounts@chrisrackauckas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Courtesy PR for the SciMLBase v3 release.
SciMLBasecompat to"1.73, 2, 3.1"(keep existing lower bound and v2 support).SciMLBase.derivative_discontinuity!(::ODEInterfaceIntegrator, ::Bool)overload insrc/integrator_utils.jlalongside the existingDiffEqBase.u_modified!method, guarded by@static if isdefined(SciMLBase, :derivative_discontinuity!).SciMLBase v3 renamed
u_modified!→derivative_discontinuity!with an@deprecateshim on the old name (src/integrator_interface.jl:242in SciMLBase). The existingu_modified!overload forODEInterfaceIntegratorstill dispatches for legacy callers, but any caller migrated to the new name would otherwise hit the genericerror("method has not been implemented for the integrator")fallback. Theisdefinedguard keeps the file compiling on SciMLBase v2.Known limitation
Local tests cannot be run:
Pkg.resolve()fails on any env containing SciMLBase 3.1 becauseOrdinaryDiffEqin the registry still pinsRecursiveArrayTools ≤ 3.54. Expect CI to fail at thePkg.addstep until upstream bumps.Reference pattern
Same
@static if isdefined(SciMLBase, :derivative_discontinuity!)shim used in SciML/DiffEqCallbacks.jl#300.cc @ChrisRackauckas
🤖 Generated with Claude Code