Skip to content

add isautonomous #810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 24, 2021
Merged

add isautonomous #810

merged 1 commit into from
Feb 24, 2021

Conversation

ChrisRackauckas
Copy link
Member

Checks for whether the ODESystem is autonomous

@shashi is there a better way to do this?

Checks for whether the ODESystem is autonomous
Copy link
Member

@YingboMa YingboMa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YingboMa YingboMa merged commit f9e4e19 into master Feb 24, 2021
@YingboMa YingboMa deleted the isautonomous branch February 24, 2021 16:49
@shashi
Copy link
Collaborator

shashi commented Feb 24, 2021

You can use jacobian_sparsity for speed.

@YingboMa
Copy link
Member

jacobian_sparsity will think that x(t) is time dependent.

@ChrisRackauckas
Copy link
Member Author

Yeah. But the method of jacobian_sparsity could be used w.r.t. t and that would speed it up.

@ChrisRackauckas
Copy link
Member Author

Opened an issue in #816 . The issue is that sparsity w.r.t. t still has D(x(t)) as non-zero, so we'd then have to zero all of those, and then use the sparsity. So it's not trivial enough to do right now, but it's something we could think about for the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants