fix: fix bad input ordering, make downstream tests pass #3804
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baggepinnen
reviewed
Jul 9, 2025
AayushSabharwal
force-pushed
the
as/control-and-error
branch
from
c9f830c to
b501098
Compare
Co-authored-by: Fredrik Bagge Carlson <baggepinnen@gmail.com>
AayushSabharwal
force-pushed
the
as/control-and-error
branch
from
b501098 to
173fc49
Compare
baggepinnen
reviewed
Jul 11, 2025
| @@ -670,6 +672,12 @@ function complete( | |||
| end | |||
| ordered_ps = vcat( | |||
| ordered_ps, reduce(vcat, ps_split; init = eltype(ordered_ps)[])) | |||
| if isscheduled(sys) | |||
There was a problem hiding this comment.
I don't quite understand where the fix to the ordering happens. Will this assert @assert issorted(input_idxs) guarantee that the order expected by the inputs when they are passed as input arguments to generated control functions is the same as the order specified by the user?
There was a problem hiding this comment.
The fix to ordering is in the IndexCache constructor - that was the problem all along. This check here just enforces the invariant.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.