Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method ambiguities reported by Aqua #384

Open
prbzrg opened this issue Dec 27, 2023 · 2 comments
Open

Method ambiguities reported by Aqua #384

prbzrg opened this issue Dec 27, 2023 · 2 comments
Labels

Comments

@prbzrg
Copy link
Member

prbzrg commented Dec 27, 2023

In Julia v1.10, I used Aqua to detect method ambiguities in my package impICNF/ContinuousNormalizingFlows.jl#356 and some of its report were related to this package:

Ambiguity #17
Base.Broadcast.BroadcastStyle(::JumpProcesses.ExtendedJumpArrayStyle{UStyle, JumpUStyle}, ::Style) where {UStyle, JumpUStyle, Style<:BroadcastStyle} @ JumpProcesses ~/.julia/packages/JumpProcesses/HPjOl/src/extended_jump_array.jl:139
Base.Broadcast.BroadcastStyle(::S, ::Base.Broadcast.Unknown) where S<:BroadcastStyle @ Base.Broadcast broadcast.jl:133

Possible fix, define
  Base.Broadcast.BroadcastStyle(::S, ::Base.Broadcast.Unknown) where {UStyle, JumpUStyle, S<:JumpProcesses.ExtendedJumpArrayStyle{UStyle, JumpUStyle}}

I would appreciate your attention to this issue.

@prbzrg prbzrg added the bug label Dec 27, 2023
@isaacsas
Copy link
Member

@ChrisRackauckas what should the suggested dispatch do? Is that a valid broadcast style combination that reuses the current corde, or should it just throw an error?

@ChrisRackauckas
Copy link
Member

I don't know. It should probably just throw an error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants