Fix VEGAS interface #195
Merged
Fix VEGAS interface #195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's just bound it. @ranjanan can you get this fixed up? |
|
ehh we might as well handle this, it's not harmful at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #193 and adds VEGAS tests back into the test suite.
Should be compatible with both MonteCarloIntegration v0.1 and v0.0.3 based on running the tests locally, but only because of an ugly hack (see related issue ranjanan/MonteCarloIntegration.jl#16 and comments in pr).
Perhaps a better approach, since we added MonteCarloIntegration@0.1 only a day ago, is to drop support for it?