Skip to content

Support Different Norms for Termination #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 31, 2024
Merged

Support Different Norms for Termination #1020

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4e6ed36
Simplify the termination code
avik-pal Mar 30, 2024
57a1fc8
Introduce internalnorm to the termination conditions
avik-pal Mar 30, 2024
0e026f3
Allow different norms
avik-pal Mar 31, 2024
b9ae9f8
Default the default norm to nothing for upstream selection
avik-pal Mar 31, 2024
7346594
Fix the testing
avik-pal Mar 31, 2024
8172d19
Update the GPU tests
avik-pal Mar 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .JuliaFormatter.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
style = "sciml"
style = "sciml"
annotate_untyped_fields_with_any = false
3 changes: 3 additions & 0 deletions .github/workflows/Downstream.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,9 @@ jobs:
@info "Not compatible with this release. No problem." exception=err
exit(0) # Exit immediately, as a success
end
env:
RETESTITEMS_NWORKERS: 4
RETESTITEMS_NWORKER_THREADS: 2
- uses: julia-actions/julia-processcoverage@v1
- uses: codecov/codecov-action@v4
with:
Expand Down
6 changes: 5 additions & 1 deletion Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
name = "DiffEqBase"
uuid = "2b5f629d-d688-5b77-993f-72d75c75574e"
authors = ["Chris Rackauckas <accounts@chrisrackauckas.com>"]
version = "6.148.0"
version = "6.149.0"

[deps]
ArrayInterface = "4fba245c-0d91-5ea0-9b3e-6abc04ee57a9"
ConcreteStructs = "2569d6c7-a4a2-43d3-a901-331e8e4be471"
DataStructures = "864edb3b-99cc-5e75-8d2d-829cb0a9cfe8"
DocStringExtensions = "ffbed154-4ef7-542d-bbb7-c09d3a79fcae"
EnumX = "4e289a0a-7415-4d19-859d-a7e5c4648b56"
EnzymeCore = "f151be2c-9106-41f4-ab19-57ee4f262869"
FastBroadcast = "7034ab61-46d4-4ed7-9d0f-46aef9175898"
FastClosures = "9aa1b823-49e4-5ca5-8b0f-3971ec8bab6a"
ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
FunctionWrappers = "069b7b12-0de2-55c6-9aab-29f3d0a68a2e"
FunctionWrappersWrappers = "77dc65aa-8811-40c2-897b-53d922fa7daf"
Expand Down Expand Up @@ -60,12 +62,14 @@ DiffEqBaseUnitfulExt = "Unitful"
[compat]
ArrayInterface = "7.8"
ChainRulesCore = "1"
ConcreteStructs = "0.2.3"
DataStructures = "0.18"
Distributions = "0.25"
DocStringExtensions = "0.9"
EnumX = "1"
EnzymeCore = "0.5, 0.6, 0.7"
FastBroadcast = "0.2"
FastClosures = "0.3.2"
ForwardDiff = "0.10"
FunctionWrappers = "1.0"
FunctionWrappersWrappers = "0.1"
Expand Down
4 changes: 4 additions & 0 deletions src/DiffEqBase.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ PrecompileTools.@recompile_invalidations begin

using Markdown

using ConcreteStructs: @concrete
using FastClosures: @closure

# Could be made optional/glue
import PreallocationTools

Expand Down Expand Up @@ -138,6 +141,7 @@ include("common_defaults.jl")
include("solve.jl")
include("internal_euler.jl")
include("forwarddiff.jl")
include("termination_conditions_deprecated.jl") # TODO: remove in the next major release
include("termination_conditions.jl")
include("norecompile.jl")

Expand Down
Loading