Skip to content

Wrap all AbstractDDEFunction which have the expected fields #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 31, 2021

Conversation

wi11dey
Copy link
Contributor

@wi11dey wi11dey commented Jan 31, 2021

Since now there are more subtypes of AbstractDDEFunction than just DDEFunction, ODEFunctionWrapper is changed to accept any AbstractDDEFunction f that fits the interface:

  • isinplace(f) returns Bool
  • f.f is defined as the one function that contains the entire DDE.
  • f.mass_matrix is defined
  • f.analytic is defined
  • f.jac is defined
  • f.jac_prototype is defined
  • f.sparsity is defined
  • f.Wfact is defined
  • f.Wfact_t is defined
  • f.paramjac is defined
  • f.syms is defined
  • f.colorvec is defined

(i.e. any AbstractDDEFunction that "looks like" a regular DDEFunction)

Companion PR of SciML/SciMLBase.jl#14.

@ChrisRackauckas ChrisRackauckas merged commit f41db7a into SciML:master Jan 31, 2021
@ChrisRackauckas
Copy link
Member

Yup great!

AbstractDDEFunction f that fits the interface:

With the SciMLBase refactor I plan to go back through and try and document all of these interfaces. It'll take a bit, but I think it'll help the ecosystem a ton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants