Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SFTPFileTransfer #136

Merged
merged 21 commits into from
Aug 28, 2023
Merged

Add SFTPFileTransfer #136

merged 21 commits into from
Aug 28, 2023

Conversation

jl-wynen
Copy link
Collaborator

Giving users full SSH access is dangerous, so at ESS, we won't use this in production. Instead, we may use SFTP. And we definitely use SFTP for an upcoming summer school.
So this PR implements a new file transfer that uses only SFTP. It is mostly a copy of SSHFileTransfer but with replacements for all SSH-specific functions.

We lose some functionality. In particular:

  • We cannot determine the timezone of the server. This is mitigated by using the upload time on the local machine in UTC as the file creation time. This is equivalent to the old method up to a small delay.
  • We currently cannot validate uploaded files. This requires computing checksums on the server. There is an extension to SFTP that can do this. But the test server and current ESS servers do not implement it.

@jl-wynen jl-wynen requested a review from nitrosx August 25, 2023 13:28
@jl-wynen
Copy link
Collaborator Author

@jl-wynen
Copy link
Collaborator Author

The build fails because it references a URL that will only exist once this PR has been merged. (A code blob on main)

@jl-wynen jl-wynen merged commit 42b0509 into main Aug 28, 2023
11 of 12 checks passed
@jl-wynen jl-wynen deleted the sftp-transfer branch August 28, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant