Skip to content

Adds Modal run and check and server #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

tcapelle
Copy link

@tcapelle tcapelle commented Mar 31, 2025

Thanks for the great repo.

I added a simple run_and_check modal so we can run this on any hardware, also added a server in modal so we can serve the run_and_check and use it on a GRPO pipeline.

  • Use uv as dependency manager and move to a more modern prproject.toml
  • Rework imports and file locations, moved to src/kernelbench to make editable install robust and best practice.
  • Use absolute path's everywhere, removed unused imports
  • I am also working on having observability on the generation part, added some weave traces here and there while I figure how this part works. I feel we could simplify a lot by using something like litellm and not handling LLM providers one by one.

@willhu-jpg
Copy link
Collaborator

Hi Thomas, thank you for the contribution! We're taking a look at your pull request.

@tcapelle
Copy link
Author

I can split the PR, let's book some time and chat about how can I help you guys. For the time being I moved to work on TritonBench instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants