Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manifest icon url generation not working properly when using an external media server #49

Open
Gandhi11 opened this issue Sep 27, 2019 · 0 comments

Comments

@Gandhi11
Copy link

If you site is using a plugin like WP Offload Media and all the medias are store in a bucket S3 for example, the the URL generated for the icon in the manifest a not working properly.

I suggest using the default get_site_icon_url() function https://developer.wordpress.org/reference/functions/get_site_icon_url/ from wordpress to properly get the icons informations instead of generating the url of the different size yourself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant