Skip to content

Commit

Permalink
[PATCH] r/o bind mounts: write counts for truncate()
Browse files Browse the repository at this point in the history
Acked-by: Al Viro <viro@ZenIV.linux.org.uk>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Hansen <haveblue@us.ibm.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
  • Loading branch information
hansendc authored and Al Viro committed Apr 19, 2008
1 parent 2af482a commit 9ac9b84
Showing 1 changed file with 8 additions and 6 deletions.
14 changes: 8 additions & 6 deletions fs/open.c
Original file line number Diff line number Diff line change
Expand Up @@ -244,21 +244,21 @@ static long do_sys_truncate(const char __user * path, loff_t length)
if (!S_ISREG(inode->i_mode))
goto dput_and_out;

error = vfs_permission(&nd, MAY_WRITE);
error = mnt_want_write(nd.path.mnt);
if (error)
goto dput_and_out;

error = -EROFS;
if (IS_RDONLY(inode))
goto dput_and_out;
error = vfs_permission(&nd, MAY_WRITE);
if (error)
goto mnt_drop_write_and_out;

error = -EPERM;
if (IS_IMMUTABLE(inode) || IS_APPEND(inode))
goto dput_and_out;
goto mnt_drop_write_and_out;

error = get_write_access(inode);
if (error)
goto dput_and_out;
goto mnt_drop_write_and_out;

/*
* Make sure that there are no leases. get_write_access() protects
Expand All @@ -276,6 +276,8 @@ static long do_sys_truncate(const char __user * path, loff_t length)

put_write_and_out:
put_write_access(inode);
mnt_drop_write_and_out:
mnt_drop_write(nd.path.mnt);
dput_and_out:
path_put(&nd.path);
out:
Expand Down

0 comments on commit 9ac9b84

Please sign in to comment.