Skip to content

R/q to add profile page 01 #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 30 commits into from
Jan 9, 2019
Merged

Conversation

dndoanh
Copy link

@dndoanh dndoanh commented Jan 7, 2019

Hi @SahSantoshh,

Please review my code of profile page 01

Thanks

nb312 and others added 29 commits December 25, 2018 11:28
…roup that its name is same as the group package.
add some picture and comply page 10 of group 05
comply the 11th pages of feed group.
comply the 12 page of group 5
# Conflicts:
#	lib/page/feed/feed_const.dart
comply the page 13 of group 5
-REMEMBER TO CLEAN AND REFACTOR THE CODE
-Page Four implemented
-Clean Code
-Const document for Shadows added

*Page Four is not finished yet, still have to add images and make it responsive.
@SahSantoshh
Copy link
Owner

In ProfilePageOne

Your back button is not working please make it workk.

line 94 function _buildPhotos,

  1. Please correct your photoCount function

line 188,

  1. please create that follow gradient button.
  2. And make that button clickable i.e onPressed use empty function with some comments. So that later only adding the function will do the job.

line 193,

Container( padding: EdgeInsets.symmetric(vertical: 15), ),

Instead of above code use following one:

SizedBox(height: 15.0,)

It is much better than using container for padding only.

line 206,

  1. Always capitalize the address first letter.

@dndoanh
Copy link
Author

dndoanh commented Jan 9, 2019

@SahSantoshh I've fixed your comments, please check it again. Tks

@SahSantoshh SahSantoshh merged commit c31a06a into SahSantoshh:master Jan 9, 2019
SahSantoshh pushed a commit that referenced this pull request Jan 24, 2019
SahSantoshh pushed a commit that referenced this pull request Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants