Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create edaPanelManager #855

Open
SmiteDeluxe opened this issue Feb 5, 2024 · 0 comments
Open

Create edaPanelManager #855

SmiteDeluxe opened this issue Feb 5, 2024 · 0 comments
Assignees
Labels
cleanup 🧹 Refactorings and other tasks that improve the code vscode 🔨 Issues regarding tools like the VS Code extension

Comments

@SmiteDeluxe
Copy link
Contributor

SmiteDeluxe commented Feb 5, 2024

Is your feature request related to a problem?

This design is a little weird. The name "EDAPanel" implies that we deal with a single panel. Yet, the class contains a public map that tracks multiple panels. Individual methods

Desired solution

I'd rather suggest creating another class, called "EDAPanelManager" or something similar. This class can then contain a private map from strings to panels and provide the logic to cache/dispose/... panels.

@SmiteDeluxe SmiteDeluxe added enhancement 💡 New feature or request vscode 🔨 Issues regarding tools like the VS Code extension labels Feb 5, 2024
@lars-reimann lars-reimann added this to DSL Feb 5, 2024
@github-project-automation github-project-automation bot moved this to Backlog in DSL Feb 5, 2024
@lars-reimann lars-reimann added cleanup 🧹 Refactorings and other tasks that improve the code and removed enhancement 💡 New feature or request labels Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Refactorings and other tasks that improve the code vscode 🔨 Issues regarding tools like the VS Code extension
Projects
Status: Backlog
Development

No branches or pull requests

2 participants