Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Problem] Incorrect media type detection with small UDF DVD #710

Open
2 tasks done
mictlantecuhtle opened this issue Jun 21, 2024 · 1 comment
Open
2 tasks done
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@mictlantecuhtle
Copy link

Version
What version are you using?

  • Stable release (Version 3.2.0-de1032a09991e1f82617ddbc38a6937fc23cf2e7)

Build
What runtime version are you using?

  • .NET 8.0 running on (Operating System)

Describe the issue
Attempt to detect media type for a very small UDF DVD-ROM (164MB) incorrectly detects the disc as a CD-ROM.

Scanning for drives..
Found 2 drives: E:\, F:\
Trying to detect system for drive F:\.. unable to detect.
Trying to detect media type for drive F:\ [UDF] using size and filesystem.. Detected CD-ROM.
Supported media speeds: 1, 2, 3, 4, 6, 8, 12, 16, 20, 24, 32, 40, 44, 48, 52, 56, 72
Setting drive speed to: 16
Local version: 3.2.0
Remote version: 3.2.0
You have the newest version!

An attempt to dump with redumper (without changing media type) will result in a successful dump but cause the process to fail at protection scan/info gathering. DIC will refuse to dump due to being passed the wrong media type.

To Reproduce
Steps to reproduce the behavior:

  1. Insert a sufficiently small DVD-ROM with a UDF filesystem
  2. Click "Scan for discs"
  3. Check to see which media type has been detected

Expected behavior

The disc to be detected as a DVD-ROM

Additional context
The disc in question is Side A of the first disc of Cartoon Network Power Pack, consisting of two double-sided discs, each with a DVD-Video and a DVD-ROM side (https://www.ebay.co.uk/itm/195943982458)

@mictlantecuhtle mictlantecuhtle added the bug Something isn't working label Jun 21, 2024
@Deterous
Copy link
Member

Deterous commented Jun 21, 2024

This is a known problem, but good to log it here on github. It comes down to there currently not being a good method for MPF to properly detect media type, and DIC requiring prior knowledge of it.
For now, the user has to correct it before dumping with DIC. At least its an error that's produced and not a bad dump. Perhaps a future version will be smart enough (without doing Windows-specific API calls, something sabre does not want in MPF).

@Deterous Deterous added the help wanted Extra attention is needed label Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants