Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added accelerator for board.show_analysis to show/hide analysis results handly. #752

Merged
merged 3 commits into from
Jul 5, 2021

Conversation

k-l-lambda
Copy link
Contributor

Go learners can use analyzer as question & answer training. So switching analysis results shown/hidden is often to use.

I chose back quote (`) as the short key, that's can be discussed.

yishn
yishn previously requested changes Nov 22, 2020
Copy link
Member

@yishn yishn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not believe a backquote is a good accelerator. Maybe CmdOrCtrl+Shift+H instead.

@apetresc apetresc force-pushed the advice/analysis-accelerator branch from 97613fc to a747648 Compare July 5, 2021 03:50
Ctrl+H toggles the heatmap, and Ctrl+Shift+H cycles through the
different labels on the heatmap.
@apetresc
Copy link
Member

apetresc commented Jul 5, 2021

As per @yishn's suggestion, I've changed the heatmap toggle to CtrlOrCmd+H and used CtrlOrCmd+Shift+H to cycle through the different heatmap labels (which is a common thing to want to see).

@apetresc apetresc self-requested a review July 5, 2021 04:05
@apetresc apetresc dismissed yishn’s stale review July 5, 2021 04:06

The requested changes were implemented

@apetresc apetresc merged commit 939ac2e into SabakiHQ:master Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants