Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for MNIST data loader and update data loading functionality #138

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

ketayon
Copy link
Contributor

@ketayon ketayon commented Oct 20, 2024

This PR addresses issue #101 by adding train_test_split functionality within the load_mnist_dataset function. Now, users no longer need to manually split the MNIST dataset into training and testing sets before loading.

Changes:

  1. Added train-test splitting based on the split_ratio argument, allowing for flexible dataset sizes.
  2. Updated the function to allow loading only the train or test dataloader, or both, enhancing usability.
  3. Added comprehensive tests in test_mnist_data_loader.py to ensure the functionality of the load_mnist_dataset function, including:
  • Verifying that the dataset splits correctly according to the specified split_ratio.
  • Testing the functionality of loading train and test dataloaders independently or together.
  • Checking that the data normalization functionality works as intended.

Let me know if any further changes are required.

@SaashaJoshi
Copy link
Owner

Hi @ketayon, thank you for the contribution. I will get back to reviewing as soon as I can. However, are you in a rush to get this done before hacktoberfest gets over?

@SaashaJoshi SaashaJoshi added the hacktoberfest-accepted Approved for Hacktoberfest label Oct 22, 2024
@ketayon
Copy link
Contributor Author

ketayon commented Oct 22, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Approved for Hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants